1907696 - Change the Suggest ingest strategy so only enabled suggestion types are ingested

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Drew Willcoxon :adw]

The Suggest Rust component doesn't ingest Fakespot suggestions by default. We have to pass the Fakespot provider as an ingest constraint to store.ingest(). I think that's reasonable since there are so many Fakespot suggestions, and they won't be enabled for most users, so they should only be ingested if the user is in the Fakespot experiment. It's reasonable in general, for all suggestion types, not only Fakespot.

Our desktop integration with the Rust component currently ingests all default suggestion types at once. We rely on the fact that empty ingest constraints cause the Rust component to ingest all suggestions it considers "default," defined here. As mentioned, all suggestion types except Fakespot are considered default.

Instead of forcing the component to always ingest Fakespot or any other suggestion type, I'd like to redesign how we do ingest. Each suggestion type should be ingested as it becomes enabled. If a suggestion type is not enabled, we shouldn't try to ingest it.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1907696 - Change the Suggest ingest strategy so only enabled suggestion types are ingested.

Please see the bug for context.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82d976ed4389
Change the Suggest ingest strategy so only enabled suggestion types are ingested. r=daisuke

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/82d976ed4389

Comment 4

[Drew Willcoxon :adw]

This bug has an effect on the quick_suggest_ingest_time telemetry probe. Please see bug 1907227 comment 6 for details.