Closed Bug 1907314 Opened 2 months ago Closed 2 months ago

Update perfetto to new version v46.0 from 2024-06-13 17:08:13

Categories

(Core :: Performance Engineering, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
130 Branch
Tracking Status
firefox130 --- fixed

People

(Reporter: update-bot, Assigned: denispal)

Details

(Whiteboard: [3pl-filed][task_id: NhBLdMqRTNeLHNSmc6KznQ])

Attachments

(1 file)

This update covers 551 commits. Here are the overall diff statistics, and then the commit information.


third_party/perfetto/moz.yaml | 4 +-
third_party/perfetto/sdk/perfetto.cc | 533 +-
third_party/perfetto/sdk/perfetto.h | 21987 +++++++++++++++++++-------------
3 files changed, 13409 insertions(+), 9115 deletions(-)


551 commits elided, as they are too long for a bugzilla comment.


Updatebot encountered an error while trying to apply the mozilla patches. with the following message:

stdout:
Importing local patches...
patch -p1 -r /dev/stdout --directory third_party/perfetto --input /builds/worker/checkouts/gecko/third_party/perfetto/moz_attributes.patch --no-backup-if-mismatch
patching file sdk/perfetto.h
Hunk #1 succeeded at 371 (offset 6 lines).
Hunk #2 succeeded at 19789 (offset 311 lines).
Hunk #3 FAILED at 19489.
1 out of 3 hunks FAILED -- saving rejects to file /dev/stdout
patch: **** Can't create file /dev/stdout : Too many levels of symbolic links
Could not apply third_party/perfetto/moz_attributes.patch, possible reasons:

  • You ran --patch-mode=only before running --patch-mode=none

  • You tried to apply the patches twice

  • The library update has modified the files so the patch no longer applies cleanly
    I am going to re-throw the exception now.
    Error running mach:

    mach vendor --patch-mode only third_party/perfetto/moz.yaml

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke ./mach busted to check if this issue is already on file. If it
isn't, please use ./mach busted file vendor to report it. If ./mach busted is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

Exception: Process executed with non-0 exit code 2: ['patch', '-p1', '-r', '/dev/stdout', '--directory', 'third_party/perfetto', '--input', '/builds/worker/checkouts/gecko/third_party/perfetto/moz_attributes.patch', '--no-backup-if-mismatch']

File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/vendor/mach_commands.py", line 130, in vendor
vendor_command.vendor(
File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/vendor/vendor_manifest.py", line 132, in vendor
self.import_local_patches(
File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/vendor/vendor_manifest.py", line 905, in import_local_patches
raise e
File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/vendor/vendor_manifest.py", line 891, in import_local_patches
self.run_process(
File "/builds/worker/checkouts/gecko/python/mach/mach/mixin/process.py", line 196, in run_process
raise Exception(f"Process executed with non-0 exit code {status}: {args}")

Updatebot will be unable to do anything more for this library version.

Flags: needinfo?(dpalmeiro)
Component: Performance → Performance Engineering
Assignee: nobody → dpalmeiro
Flags: needinfo?(dpalmeiro)
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: