1907368 - Replace AMO collection screen with Addons Picker in about:welcome defaults

Status: VERIFIED FIXED

(Firefox :: Messaging System, task, P1)

Description

[Emily McMinn :emcminn]

Based on the improvement to addon installations in onboarding seen in this experiment, we should replace the AMO collection screen in the about:welcome defaults with the addons picker. We can use the addons from the more successful branch (Privacy.)

See also: https://docs.google.com/document/d/1U9a02UU8wXITklEg7oDE6dT1aTyImY38mqtpbGy_65w/edit#heading=h.5840t7jz7l1f

Comment 1

[Emily McMinn :emcminn]

Attachment: Bug 1907368 - Replace AMO collection screen with addons picker in about:welcome

Comment 2

[Meg Viar [:mviar]]

This will need to include translation of these strings. Also note that bug 1908210 will make the install label configurable and our goal is to uplift this into 129 release.

Comment 3

[Emily McMinn :emcminn]

(In reply to Meg Viar [:mviar] from comment #2)

This will need to include translation of these strings. Also note that bug 1908210 will make the install label configurable and our goal is to uplift this into 129 release.

So while I agree we should land the addons picker strings in the translated file, I don't think it needs to necessarily block this. The original intention was to land it with the same screen targeting as the AMO collection (i.e. targeting: "localeLanguageCode == 'en'") so that it would be available to EN locales immediately, and then follow up with translations and remove the en-* only targeting once experimentation had been done.

Comment 4

[Meg Viar [:mviar]]

(In reply to Emily McMinn :emcminn from comment #3)

(In reply to Meg Viar [:mviar] from comment #2)

This will need to include translation of these strings. Also note that bug 1908210 will make the install label configurable and our goal is to uplift this into 129 release.

So while I agree we should land the addons picker strings in the translated file, I don't think it needs to necessarily block this. The original intention was to land it with the same screen targeting as the AMO collection (i.e. targeting: "localeLanguageCode == 'en'") so that it would be available to EN locales immediately, and then follow up with translations and remove the en-* only targeting once experimentation had been done.

Thanks, Emily. That makes sense to me if we're just targeting EN locales to start. FYI we've pushed back the localized experiment until after bug 1908210 lands so that we can localize the install buttons (so likely Fx129 or Fx130 release).

Comment 5

[Emily McMinn :emcminn]

I've updated the addons in the picker to reflect Scott's feedback on OMC-752; this should be ready!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf43aa62c099
Replace AMO collection screen with addons picker in about:welcome r=omc-reviewers,mviar

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c59d951eb773
Fix failures about browser_all_files_referenced. a=test-only

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/bf43aa62c099
https://hg.mozilla.org/mozilla-central/rev/c59d951eb773

Comment 9

[:Gijs (he/him)]

(In reply to Pulsebot from comment #7)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c59d951eb773
Fix failures about browser_all_files_referenced. a=test-only

This added an exception for this file but all references for the file are gone. Shouldn't the file be removed instead?

Comment 10

[Emily McMinn :emcminn]

The file is still referenced in some messages that are live on RS, similar to the mr-privacysegmentation.svg. We're also actively experimenting with messaging around addons/addons collections so there's a good chance we'll have new use cases for that illustration in the near future.

We could always take a look at moving those files that have exceptions over to RS and using them from there - that would shrink the installer size by a tiny bit (the images are optimized to be pretty small), but would potentially have an impact on perceived load times as the images are fetched from RS.

Comment 11

[:Gijs (he/him)]

(In reply to Emily McMinn :emcminn from comment #10)

The file is still referenced in some messages that are live on RS, similar to the mr-privacysegmentation.svg. We're also actively experimenting with messaging around addons/addons collections so there's a good chance we'll have new use cases for that illustration in the near future.

Ah, thanks for clarifying! Do we have a bug on file to add automated testing (assuming it doesn't exist already) that would flag any resources like this once we do stop using the resources from such live RS messages?

We could always take a look at moving those files that have exceptions over to RS and using them from there - that would shrink the installer size by a tiny bit (the images are optimized to be pretty small), but would potentially have an impact on perceived load times as the images are fetched from RS.

Based on the pros/cons you describe that doesn't sound worth pursuing at the moment, especially for about:welcome as it's used straight after startup.

Comment 12

[Emily McMinn :emcminn]

(In reply to :Gijs (he/him) from comment #11)

Ah, thanks for clarifying! Do we have a bug on file to add automated testing (assuming it doesn't exist already) that would flag any resources like this once we do stop using the resources from such live RS messages?

We don't AFAIK! That would be handy. I'm curious if there's a way we could leverage the Skylight tool for this, since it's intended to give us a clearer overview of what messages are live/ "in-flight" at any given time. I'll bring it to the team and maybe we can come up with something :)

Comment 13

[Marius Coman [:mcoman], Ecosystem QA - PTO until 8th of November, for any requests ping :cmuresan]

I have verified this task and can confirm that the "Addons Picker" screen is displayed instead of the "AMO collection" one on the "about:welcome" page.

Verified using the latest Firefox Nightly 131.0a1 (Build ID: 20240821160637) installed on Windows 10 x64, macOS 14.5, and Ubuntu 22.04 x64.