1907479 - empty bar exists above android navigation bar/at bottom of window (nightly)

Status: RESOLVED FIXED

(Fenix :: Toolbar, defect)

Description

[cre]

Attachment: Screenshot_20240712-124131_Firefox Nightly.jpg

User Agent: Mozilla/5.0 (Android 12; Mobile; rv:130.0) Gecko/130.0 Firefox/130.0

Steps to reproduce:

have firefox nightly installed on android tablet and phone. set address bar location to "top".

nightly updates overnight to version 130.0a1 (1am AEST, 12 July 2024).

open nightly this morning to discover new toolbar and this bug

Actual results:

the toolbar update has added an empty dark purple bar at the bottom of the nightly window when on webpages. it looks like part of the android nav bar initially, but only exists in nightly and moves above the keyboard when it's opened so is not anchored to the nav bar. it does not appear on firefox full-page menus such as the extension manager. it does not cut off the bottom of webpages.

it exists in both horizontal and vertical mode on tablet and in horizontal mode on phone, but when phone is used vertically it contains the back, forward, new tab, tab list button and hamburger menu button. these buttons stay in the same toolbar as the address bar when tablet is used vertically.

Expected results:

when device is in horizontal orientation, and if when it's in vertical orientation the screen size is large enough to keep all buttons in the address bar toolbar area, no empty space should appear where the buttons would otherwise go.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:mavduevskiy, since you are the author of the regressor, bug 1902798, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Roger Yang [:royang]]

Can't reproduce, but with the information that in vertical mode the user saw the buttons in the navigation bar, it looks like there's a case where we added the navigation bar but didn't add the buttons.

Comment 3

[Roger Yang [:royang]]

Attachment: Bug 1907479 - Include tab strip settings when determining navigation bar visibility

Comment 4

[cre]

this appears to be the same issue as reported in Bug 1907638

Comment 5

[cre]

(In reply to Roger Yang [:royang] from comment #2)

Can't reproduce, but with the information that in vertical mode the user saw the buttons in the navigation bar, it looks like there's a case where we added the navigation bar but didn't add the buttons.

not sure if this is helpful in identifying why this is happening, but I've just observed that if nightly is used in split screen and vertical modes on the tablet, the buttons are present, and then remain when the tablet returns to horizontal mode without split screen. so far they are remaining even after leaving nightly and returning, but I'm not certain of the long term stability of this. the buttons do disappear when the keyboard is open, but reappear when it closes.

now all the buttons exist twice, once in the top toolbar and then again in the newly visible bottom toolbar. if I may give a personal opinion as a user, I would rather this be solved by removing the bottom toolbar if the top toolbar is wide enough to fit these buttons, than the buttons now in the bottom toolbar be removed from the top toolbar. it's less obstructive to browsing to have one toolbar instead of two.

Comment 6

[cre]

(cannot find an edit button, consider this an addition to the final sentence of my last comment) and removing the bottom toolbar reduces the chance of accidentally hitting a button in the android nav bar when aiming for a button in the bottom firefox toolbar, and vice versa.

Comment 7

[cre]

(In reply to cre from comment #5)

[...] I'm not certain of the long term stability of this. [...]

update: completely closing nightly (instead of just switching apps) and then reopening it reverts back to the empty bottom toolbar.

Comment 8

[Roger Yang [:royang]]

Thanks for the new information. The split screen case is interesting. I'll investigate.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8fb3cf4a1e63
Include tab strip settings when determining navigation bar visibility r=android-reviewers,tchoh

Comment 10

[Mike a [:mavduevskiy]]

Hi! Thank for you reporting the bug!

Just to confirm the conditions under which the app was running – do you have "scroll to hide address bar and toolbar" on or off, when you experience the bug?

Comment 11

[Mike a [:mavduevskiy]]

possibly, a duplicate of 1907638.

Comment 12

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/8fb3cf4a1e63

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1902798

Comment 14

[cre]

(In reply to Mike a [:mavduevskiy] from comment #10)

Hi! Thank for you reporting the bug!

Just to confirm the conditions under which the app was running – do you have "scroll to hide address bar and toolbar" on or off, when you experience the bug?

sorry for the late reply - off for both devices, and I didn't think to test what happened if I turned it on (I have since removed the bottom toolbar altogether with the secret settings)