Closed Bug 1902798 Opened 3 months ago Closed 2 months ago

[toolbar redesign] enable navbar on nightly

Categories

(Fenix :: Toolbar, task, P1)

Product:
Fenix
Component:
Toolbar
Platform:
All
Android
Type:
task

Tracking

(firefox128 disabled, firefox129 disabled, firefox130 fixed)

Status:
RESOLVED FIXED
Milestone:
130 Branch
Tracking Flags:
Tracking Status
firefox128 --- disabled
firefox129 --- disabled
firefox130 --- fixed

People

(Reporter: mavduevskiy, Assigned: mavduevskiy)

References

(Regressed 2 open bugs)

Details

(Whiteboard: [fxdroid])

Attachments

(2 files, 4 obsolete files)

Bug 1902798 - part 1: Enable navbar in nightly
48 bytes, text/x-phabricator-request
Details | Review
Bug 1902798 - part 2: Refactor ToolbarView
48 bytes, text/x-phabricator-request
Details | Review
No description provided.
Assignee: nobody → mavduevskiy

Complete flag will be set to true by default and, backed by Nimbus experiment, used in the feature rollout. Incomplete flag enables continuous development of the feature, available only in nightly and dev builds. Rephrased the Complete flag's name, to be consistent with the the Feature flag.

If visibility of the secrete settings toggle and the feature flag controlling the settings diverge, it will be a problem. The feature flag should also determine the visibility of the secret settings.

Attachment #9407706 - Attachment description: WIP: Bug 1902798 - Refactor toolbar redesign feature flags and settings → Bug 1902798 - Refactor toolbar redesign feature flags and settings
Attachment #9407707 - Attachment description: WIP: Bug 1902798 - Refactor incomplete redesign secret settings → Bug 1902798 - Refactor incomplete redesign secret settings

The wrapper hasn't been properly used in this 6 months, and dosn't add much even after enabling the feature in nightly. Using settings directly is enough, more consistent with other features and less verbose.

Attachment #9407706 - Attachment description: Bug 1902798 - Refactor toolbar redesign feature flags and settings → WIP: Bug 1902798 - Refactor toolbar redesign feature flags and settings
Attachment #9407707 - Attachment description: Bug 1902798 - Refactor incomplete redesign secret settings → WIP: Bug 1902798 - Refactor incomplete redesign secret settings
Attachment #9407710 - Attachment description: Bug 1902798 - Switch from using incomplete to complete toolbar feature → WIP: Bug 1902798 - Switch from using incomplete to complete toolbar feature
Attachment #9407711 - Attachment description: Bug 1902798 - Remove RedesignToolbarFeature → WIP: Bug 1902798 - Remove RedesignToolbarFeature
Attachment #9407706 - Attachment description: WIP: Bug 1902798 - Refactor toolbar redesign feature flags and settings → Bug 1902798 - Refactor toolbar redesign feature flags and settings
Attachment #9407707 - Attachment description: WIP: Bug 1902798 - Refactor incomplete redesign secret settings → Bug 1902798 - Refactor incomplete redesign secret settings
Attachment #9407710 - Attachment description: WIP: Bug 1902798 - Switch from using incomplete to complete toolbar feature → Bug 1902798 - Switch from using incomplete to complete toolbar feature
Attachment #9407711 - Attachment description: WIP: Bug 1902798 - Remove RedesignToolbarFeature → Bug 1902798 - Remove RedesignToolbarFeature

This bug is a Nightly blocker.

Severity: -- → N/A
Priority: -- → P1
Attachment #9407706 - Attachment is obsolete: true
Attachment #9407711 - Attachment is obsolete: true
Whiteboard: [fxdroid]
Attachment #9408701 - Attachment description: WIP: Bug 1902798 - Enable navbar in nightly → WIP: Bug 1902798 - part 1: Enable navbar in nightly

Moving tab counter and menu from HomeFragment into the ToolbarView, to unload HomeFragment from UI logic.

Attachment #9407707 - Attachment is obsolete: true
Attachment #9407710 - Attachment is obsolete: true
Attachment #9409318 - Attachment description: WIP: Bug 1902798 - part 2: Refactor ToolbarView → Bug 1902798 - part 2: Refactor ToolbarView
Attachment #9408701 - Attachment description: WIP: Bug 1902798 - part 1: Enable navbar in nightly → Bug 1902798 - part 1: Enable navbar in nightly
Pushed by mavduevskiy@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8378c048ba75
part 1: Enable navbar in nightly r=android-reviewers,skhan
https://hg.mozilla.org/integration/autoland/rev/2ed46bf1ae1d
part 2: Refactor ToolbarView r=android-reviewers,skhan

https://hg.mozilla.org/mozilla-central/rev/8378c048ba75
https://hg.mozilla.org/mozilla-central/rev/2ed46bf1ae1d

Status: NEW → RESOLVED
Closed: 2 months ago
status-firefox130: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch
Regressions: 1907338
Regressions: 1907479
Regressions: 1907504
Regressions: 1907373
Regressions: 1907502
Regressions: 1907514
Regressions: 1907519
Regressions: 1907484
Regressions: 1907499
Regressions: 1908954
Regressions: 1908950
Regressions: 1909180
Regressions: 1909258
Depends on: 1907514
No longer regressions: 1907514
Regressions: 1910628
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: