1907599 - Nav Bar CFR does not update the `lastCfrShownTimeInMillis` variable in `Settings.kt`

Status: RESOLVED FIXED

(Fenix :: Toolbar, defect, P2)

Description

[Nicholas Poon [:Nick]]

All CFRs should update the lastCfrShownTimeInMillis variable in Settings.kt after being dismissed. As a part of this ticket, add the following line to the onDismiss lambda for the nav bar, which is here:
context.settings().lastCfrShownTimeInMillis = System.currentTimeMillis(). This is similar to what is done here

Comment 1

[Chris Peterson [:cpeterson]]

Sarah, will our nav bar CFR still show when we want it to if we start setting lastCfrShownTimeInMillis = System.currentTimeMillis()? Do we still need to set shouldShowNavigationBarCFR = false?

Looks like there are many callers setting context.settings().lastCfrShownTimeInMillis = System.currentTimeMillis(). Perhaps more of this CFR logic can be consolidated and encapsulated inside Settings object functions so we only have to fix the CFRs in one place?

Comment 2

[Nicholas Poon [:Nick]]

Hey Chris, thanks for the comment. The nav bar CFR will still show when it should without setting lastCfrShownTimeInMillis = System.currentTimeMillis(). However, there are other CFRs (i.e. Add Private Tab to Home, Inactive Tabs, Tab Auto Close Banner, PWA) that will only appear if a CFR has not been shown in at least 3 days. My guess is that the navigation bar is essential enough in which we don't delay showing its CFR but other CFRs can be delayed a bit until it is shown (to avoid overwhelming the user).

Comment 3

[[:skhan]]

I agree here with Nick's above comment. Navigation bar CFR is the first CFR that we show on home screen today so it does not require to set lastCfrShownTimeInMillis.

Comment 4

[[:skhan]]

Attachment: Bug 1907599 - Update lastCfrShownTimeInMillis for Navigation Bar CFR

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ed90ce056be
Update lastCfrShownTimeInMillis for Navigation Bar CFR r=android-reviewers,tchoh

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/6ed90ce056be