1907661 - [Toolbar Redesign] Button ripple effect is not applying theme correctly on some toolbar buttons

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, defect, P3)

Description

[eclaudiu64]

Attachment: mobizen_20240712_225254.mp4

User Agent: Mozilla/5.0 (Android 11; Mobile; rv:130.0) Gecko/130.0 Firefox/130.0

Steps to reproduce:

Enable hidden setting: Navigation Toolbar. The buttons in the new Navigation toolbar have no color when pressed, on a dark theme. It is black color on tap, on dark theme. Only the tray with tabs has color when pressed, but when I press a little on the side it is also not noticeable.

Actual results:

The colors from pressing the buttons on the new Toolbar.

Expected results:

Buttons to display a white circle on dark theme.

Comment 1

[Chris Peterson [:cpeterson]]

Thanks! Adding this bug to our Toolbar beta milestone.

Comment 2

[tchoh]

Spoke with Petru. Might not be as easy of a fix as initial thoughts. Will time-box to 1 hr and see if there is a good fix. Otherwise, this ticket will be pushed back to a later time.

Comment 3

[Chris Peterson [:cpeterson]]

Tim says this bug doesn't need to block our Beta milestone, but we should track it for our Release milestone (meta bug 1894470).

Roger says this issue might be fixed in the upcoming Compose 1.7 release, which is now in RC.

Comment 4

[Zac McKenney [:zmckenney]]

Attachment: Bug 1907661 - Add Ripple color to FirefoxTheme and apply to navigation toolbar

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/281be4770155
Add Ripple color to FirefoxTheme and apply to navigation toolbar r=android-reviewers,petru

Comment 6

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/281be4770155