1907755 - Perf regression on a dwitter demo with canvas (d2d/gpu/skia)

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Mayank Bansal]

Use wither d2d/canvas or gpu-canvas or skia-canvas.
Go to https://www.dwitter.net/d/32110

AR: The GPU use is 75% and the demo stutters.

GPU-canvas (bad): https://share.firefox.dev/4bJMrgb .
D2d-canvas (bad): https://share.firefox.dev/3zQsl6n

ER: Very smooth like previously. Chrome too is smooth here. In fact, we were better than Chrome here. Chrome takes 100% GPU while Firefox took only 25%.

Bisection:
Bug 1878884 - Keep RecordedTextureData snapshot around until it actually changes. r=aosmond
Differential Revision: https://phabricator.services.mozilla.com/D201164

Comment 1

[Mayank Bansal]

Attachment: about:support

Comment 2

[Mayank Bansal]

Attachment: Standlone_Testcase.html

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1878884

:lsalzman, since you are the author of the regressor, bug 1878884, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 4

[Lee Salzman [:lsalzman]]

Attachment: Bug 1907755 - Avoid inadvertent copies when drawing a canvas to itself. r?aosmond

Even though drawing a canvas to itself tries to use ExtractSubrect to get a limited
copy where applicable, the canvas still inadvertently forces the copy-on-write snapshot
to also force a copy due to SurfaceFromElementResult holding a subversive extra reference
to the snapshot, keeping it alive when it need not be.

RecordedTextureData also holds a reference to the snapshot that needs to be cleaned up
as well when the DT is modified.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88084791c60f
Avoid inadvertent copies when drawing a canvas to itself. r=aosmond

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/88084791c60f

Comment 7

[Mayank Bansal]

Profile with latest Nightly: https://share.firefox.dev/3Lm2pSS
We are back to pre-regression levels of perf and GPU use.

Comment 8

[Monica Chiorean]

On Win11 using FF build 130.0a1 the CPU was much higher then on FF build 130.0b1 and after the fix the canvas moved much faster. Marking issue as verified.