Closed Bug 1907879 Opened 4 months ago Closed 3 months ago

Hide the top border of the toolbar so the prompt looks like it's part of the same visual element

Categories

(Fenix :: Experimentation and Telemetry, task, P2)

Product:
Fenix
Component:
Experimentation and Telemetry
Platform:
All
Android
Type:
task

Tracking

(firefox130 fixed, firefox131 verified)

Status:
VERIFIED FIXED
Milestone:
131 Branch
Tracking Flags:
Tracking Status
firefox130 --- fixed
firefox131 --- verified

People

(Reporter: towhite, Assigned: towhite)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxdroid][group2])

Attachments

(18 files, 1 obsolete file)

Bug 1907879 - Removed the toolbar top divider when the microsurvey prompt is displayed
48 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details | Review
home top dark.mp4
70.21 KB, video/mp4
Details
home top light.mp4
57.58 KB, video/mp4
Details
home bottom dark.mp4
54.38 KB, video/mp4
Details
home bottom light.mp4
58.22 KB, video/mp4
Details
browser top dark.mp4
865.64 KB, video/mp4
Details
browser top light.mp4
888.11 KB, video/mp4
Details
browser bottom light.mp4
900.59 KB, video/mp4
Details
browser bottom dark.mp4
753.36 KB, video/mp4
Details
navbar browser bottom light.mp4
994.07 KB, video/mp4
Details
navbar broswer bottom dark.mp4
805.34 KB, video/mp4
Details
navbar browser top light.mp4
854.08 KB, video/mp4
Details
navbar broswer top dark.mp4
916.21 KB, video/mp4
Details
navbar home bottom light.mp4
62.29 KB, video/mp4
Details
navbar home bottom dark.mp4
62.63 KB, video/mp4
Details
navbar home top light.mp4
45.42 KB, video/mp4
Details
navbar home top dark.mp4
52.86 KB, video/mp4
Details
Before-After Example.jpg
333.51 KB, image/jpeg
Details

The top toolbar border should be removed if the microsurvey is displayed so it looks like a single visual element. When the prompt is closed, the toolbar should return to the original state.

Assignee: nobody → towhite
Duplicate of this bug: 1907943
Attached file WIP: Bug 1907879 (obsolete) —
Attachment #9413309 - Attachment is obsolete: true
Attached video home top dark.mp4 —
Attached video home top light.mp4 —
Attached video home bottom dark.mp4 —
Attached video home bottom light.mp4 —
Attached video browser top dark.mp4 —
Attached video browser top light.mp4 —
Attached video browser bottom dark.mp4 —
Attachment #9413490 - Attachment description: WIP: Bug 1907879 - WIP → Bug 1907879 - Removed the toolbar top divider when the microsurvey prompt is displayed
Attachment #9413490 - Attachment description: Bug 1907879 - Removed the toolbar top divider when the microsurvey prompt is displayed → WIP: Bug 1907879 - Removed the toolbar top divider when the microsurvey prompt is displayed
Attachment #9413490 - Attachment description: WIP: Bug 1907879 - Removed the toolbar top divider when the microsurvey prompt is displayed → Bug 1907879 - Removed the toolbar top divider when the microsurvey prompt is displayed
Flags: qe-verify+
Pushed by icedicedcoffee@proton.me: https://hg.mozilla.org/integration/autoland/rev/0bef67f98d4c Removed the toolbar top divider when the microsurvey prompt is displayed r=android-reviewers,amejiamarmol

https://hg.mozilla.org/mozilla-central/rev/0bef67f98d4c

Status: NEW → RESOLVED
Closed: 3 months ago
status-firefox131: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 131 Branch

Verified as fixed on the latest Nightly build (131.0a1 from 2024-08-13).

Devices used:

  • Samsung Galaxy S23 Ultra (Android 14);
  • Samsung Galaxy Z Fold 4 (Android 14);
  • Google Pixel 7 (Android 15);

Marking the ticket as verified on 131.

Status: RESOLVED → VERIFIED
status-firefox131: fixed → verified
Flags: qe-verify+
status-firefox130: --- → ?
status-firefox130: ? → ---

Comment on attachment 9413490 [details]
Bug 1907879 - Removed the toolbar top divider when the microsurvey prompt is displayed

Beta/Release Uplift Approval Request

  • User impact if declined: Microsurvey prompt will not be displayed as intended
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): UI change only, verified in Nightly
  • String changes made/needed:
  • Is Android affected?: No
Attachment #9413490 - Flags: approval-mozilla-beta?

Comment on attachment 9413490 [details]
Bug 1907879 - Removed the toolbar top divider when the microsurvey prompt is displayed

Approved for 130.0b7.

Attachment #9413490 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Regressions: 1915456
Regressions: 1914524
Regressions: 1912854

Another side-effect of increased size of the toolbar is content block scrolling got (more) broken.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: