1915456 - [toolbar redesign] transparent spacing under the toolbar top border

Status: RESOLVED FIXED

(Fenix :: Experimentation and Telemetry, defect)

Description

[Mike a [:mavduevskiy]]

Attachment: Screenshot 2024-08-28 at 11.09.09 AM.png

Steps to reproduce

Preconditions: nightly, navbar on, toolbar position bottom

1. Open home page
2. Scroll the page up and down and watch the top border of the toolbar.

Expected behavior

The toolbar has solid background

Actual behavior

There is transparent spacing between the top edge of the toolbar and its shadow.

Device information

• Firefox version:
• Android device model:
• Android OS version:

Any additional information?

On the screenshot you can see the comparison of the current state and a reverted 1907879 patch, that introduced the spacing.

Comment 1

[Mike a [:mavduevskiy]]

Hey, Tom.

Could you help me to estimate the size of the change needed to get rid of that spacing? Thank you in advance :)

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1907879

Comment 3

[Mike a [:mavduevskiy]]

It looks like the extra space to the top of the toolbar also started causing scrolling issues – 1912854

Comment 4

[Mike a [:mavduevskiy]]

Another side-effect of increased size of the toolbar is content block scrolling got (more) broken.

Comment 5

[twhite]

Attachment: Bug 1915456 - Fix transparent spacing under the toolbar top border

Comment 6

[twhite]

The issue in this bug is that the Divider() was being applied regardless of whether the microsurvey prompt was being displayed or not, leading to it being added unnecessarily - fixed by only adding the Divider() when required and the toolbar has been updated to remove the existing border.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d90111f07fc
Fix transparent spacing under the toolbar top border r=android-reviewers,amejiamarmol

Comment 8

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/9d90111f07fc