1907933 - [Menu Redesign] Design and implement Customize Reader View

Status: RESOLVED FIXED

(Fenix :: Toolbar, task, P1)

Comment 1

[Aarjav [:aarjav]]

Added design for it here - https://www.figma.com/design/RFz9fYtotQCQuinwcZujZt/Menu-Redesign?node-id=10858-66348&t=UF0WGEIgJ7ZQADI7-4

Requirement -

• When the reader view is turned on, the user will get access to the ‘Customize Reader View’ feature which is added below the reader view feature.
• The customize reader view feature does not have an active state, because this customization setting would apply to all websites/tabs that have this feature turned on and not just this website.
• We would also need to add telemetry to understand the usage of this feature when available and to find a better placement for this feature as this placement isn't ideal.

Comment 2

[Aarjav [:aarjav]]

The icon has been updated in the link shared above.

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1907933 - Part 1: Add mozac_ic_reader_view_customize_24.xml icon

• Adds the reader view cusstomize icon from https://github.com/FirefoxUX/acorn-icons/blob/main/icons/mobile/24/xml/ic_reader_view_customize_24.xml

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1907933 - Part 2: Add string for "Customize Reader View"

Figma: https://www.figma.com/design/RFz9fYtotQCQuinwcZujZt/Menu-Redesign?node-id=10858-66348&t=UF0WGEIgJ7ZQADI7-4

Comment 5

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1907933 - Part 1: Add mozac_ic_reader_view_customize_24.xml icon

• Adds the reader view cusstomize icon from https://github.com/FirefoxUX/acorn-icons/blob/main/icons/mobile/24/xml/ic_reader_view_customize_24.xml

Comment 6

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1907933 - Part 2: Add string for "Customize Reader View"

Figma: https://www.figma.com/design/RFz9fYtotQCQuinwcZujZt/Menu-Redesign?node-id=10858-66348&t=UF0WGEIgJ7ZQADI7-4

Comment 7

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1907933 - Part 3: Implement "Customize Reader View" menu item

• Figma: https://www.figma.com/design/RFz9fYtotQCQuinwcZujZt/Menu-Redesign?node-id=10858-66348&t=UF0WGEIgJ7ZQADI7-4

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82e774abef20
Part 1: Add mozac_ic_reader_view_customize_24.xml icon r=android-reviewers,sanchaai,007
https://hg.mozilla.org/integration/autoland/rev/7a3d2c81f2d5
Part 2: Add string for "Customize Reader View" r=android-reviewers,sanchaai
https://hg.mozilla.org/integration/autoland/rev/5879b34b5577
Part 3: Implement "Customize Reader View" menu item r=android-reviewers,petru

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/82e774abef20
https://hg.mozilla.org/mozilla-central/rev/7a3d2c81f2d5
https://hg.mozilla.org/mozilla-central/rev/5879b34b5577