Closed
Bug 190825
Opened 22 years ago
Closed 22 years ago
add junk envelope to messages that are junk
Categories
(SeaMonkey :: MailNews: Message Display, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.3final
People
(Reporter: sspitzer, Assigned: sspitzer)
References
()
Details
(Keywords: icon, Whiteboard: [adt1][important for junk feature])
Attachments
(1 file, 6 obsolete files)
26.77 KB,
patch
|
Details | Diff | Splinter Review |
add junk envelope to messages that are junk see http://www.mozilla.org/mailnews/specs/spam/ and http://www.mozilla.org/mailnews/specs/spam/images/Spam5.gif This will help discoverability, and is needed for stand alone msg window users to know if a message is junk or not.
Assignee | ||
Comment 1•22 years ago
|
||
accepting.
Status: NEW → ASSIGNED
Keywords: nsbeta1
Whiteboard: [important for junk feature]
Target Milestone: --- → mozilla1.3final
*** Bug 180010 has been marked as a duplicate of this bug. ***
Assignee | ||
Updated•22 years ago
|
QA Contact: laurel → esther
Assignee | ||
Comment 3•22 years ago
|
||
gail, do you have cycles to create a transparent junk icon (like the toolbar junk icon) for the junk toolbar? the toolbar icon has a toolbar background to it, if that makes sense. I'd need modern and classic, if possible. for now, I'll just use the junk toolbar icon.
Keywords: icon
Assignee | ||
Comment 4•22 years ago
|
||
1) make sure ok with stand alone, 3 pane, alt three pane 2) do it as overlay 3) ok with start page, and account central 4) use up to date xul in the bar (see neil's comments in that other bug) 5) clean up UI (better icon, border, color) 6) perf issues? 7) cleaner better design (junk status agnostic? pass around the message key / uri?) 8) issue of when switching from two messages, junk to not junk, does the junk UI stay up? see my XXX todo comment.
Assignee | ||
Comment 5•22 years ago
|
||
more todo: 1) make sure plays nice with start page 2) make sure to add back "(images not displayed)" text when that actually works 3) make sure switching folder, no message, the thing is hidden. (try load junk switch folder)
Attachment #114038 -
Attachment is obsolete: true
Assignee | ||
Comment 6•22 years ago
|
||
Attachment #114039 -
Attachment is obsolete: true
>8) issue of when switching from two messages, junk to not junk, does the junk
>UI stay up?
Junk envelope header would be removed from a msg if it is currently identified
as Junk and marked Not Junk. Also removed when switching from a Junk msg to a
Not Junk msg.
Comment 8•22 years ago
|
||
Mail triage team: nsbeta1+/adt1
Assignee | ||
Comment 9•22 years ago
|
||
sorry jen, the issue I listed in http://bugzilla.mozilla.org/show_bug.cgi?id=190825#c4 wasn't a UI issue, it was a note to myself about something I needed to fix in the code. the junk bar behaves as you'd expect.
Assignee | ||
Comment 10•22 years ago
|
||
follows some suggestions neil has made to me in the past (see http://bugzilla.mozilla.org/show_bug.cgi?id=168236#c6) [plus some other changes in my tree, which I won't be checking in]
Attachment #114046 -
Attachment is obsolete: true
Assignee | ||
Comment 11•22 years ago
|
||
Attachment #114400 -
Attachment is obsolete: true
Assignee | ||
Comment 12•22 years ago
|
||
an updated todo list: 1) ok with start page, and account central 2) clean up UI (better icon, border, color) 3) perf issues? 4) cleaner better design (junk status agnostic? pass around the message key / uri?) 5) issue of when switching from two messages, junk to not junk, does the junk UI stay up? see my XXX todo comment. 6) make sure to add back "(images not displayed)" text when that actually works 7) make sure switching folder, no message, the thing is hidden. (try load junk switch folder)
Assignee | ||
Updated•22 years ago
|
Flags: blocking1.3?
Assignee | ||
Comment 13•22 years ago
|
||
Attachment #114401 -
Attachment is obsolete: true
Comment 14•22 years ago
|
||
Not gonna block for this but we'd consider a patch for the branch.
Flags: blocking1.3? → blocking1.3-
Assignee | ||
Comment 15•22 years ago
|
||
Attachment #115110 -
Attachment is obsolete: true
Assignee | ||
Comment 16•22 years ago
|
||
fixed, this has r/sr=bienvenu there are a few cleanup issues, which I'll log as spin off bugs.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 17•22 years ago
|
||
fixed on the trunk, I should say. let's bake this before taking on the 1.3 branch.
Assignee | ||
Comment 18•22 years ago
|
||
this fix has a perf regression, but the fix is in hand. so if this makes it to 1.3 final (I hope it does) the fix for #195354 would be a part of it.
Comment 19•22 years ago
|
||
Using build 20030228 on winxp, linux and mac osx the envelope is: there for junk mail, not there for not junk mail there when junk mail header switched to all there for junk mail imap, pop and local there when header is collapsed Verified
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•