1908312 - Update settings UI to clarify that PPA is disabled when telemetry is disabled

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[:Gijs (he/him)]

Right now in the Firefox settings, the UI state for PPA remains checked and active even when the main telemetry setting is disabled. This is confusing UX, since DAP submission is disabled when telemetry is disabled. IOW, transmitting PPA is disabled when telemetry is disabled, and the UI should reflect that.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1908312 - Make it clear in about:preferences that PPA is disabled when telemetry is disabled, r?bgrins

Right now the UI state for PPA remains checked and active even when the main telemetry
setting is disabled. This is confusing UX, since DAP submission is disabled when
telemetry is disabled.

Also migrate off the deprecated toolkit-private isTelemetryEnabled() accessor to the normal pref check.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ebe73cc1ef3
Make it clear in about:preferences that PPA is disabled when telemetry is disabled, r=bgrins,settings-reviewers,firefox-desktop-core-reviewers ,mossop

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b72f696abcba
add missing define for staticprefs, rs=bustage

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/5ebe73cc1ef3
https://hg.mozilla.org/mozilla-central/rev/b72f696abcba

Comment 5

[Peter Magyari (Desktop QA)]

Verified fixed using Firefox Nightly 130.0a1 (20240717212306) on MacOS 14.4, Windows 10 and Ubuntu 24.04.

Cc["@mozilla.org/private-attribution;1"].getService(Ci.nsIPrivateAttributionService).wrappedJSObject.isEnabled() returns the correct value according to the checkbox's state.

Comment 6

[:Gijs (he/him)]

Attachment: Bug 1908312 - Make it clear in about:preferences that PPA is disabled when telemetry is disabled, r?bgrins

Right now the UI state for PPA remains checked and active even when the main telemetry
setting is disabled. This is confusing UX, since DAP submission is disabled when
telemetry is disabled.

Also migrate off the deprecated toolkit-private isTelemetryEnabled() accessor to the normal pref check.

Original Revision: https://phabricator.services.mozilla.com/D216801

Comment 7

[:Gijs (he/him)]

Attachment: Bug 1908312 - Make it clear in about:preferences that PPA is disabled when telemetry is disabled,

Right now the UI state for PPA remains checked and active even when the main telemetry
setting is disabled. This is confusing UX, since DAP submission is disabled when
telemetry is disabled.

Also migrate off the deprecated toolkit-private isTelemetryEnabled() accessor to the normal pref check.

Original Revision: https://phabricator.services.mozilla.com/D216801

Comment 8

[:Gijs (he/him)]

Attachment: Bug 1908312 - Make it clear in about:preferences that PPA is disabled when telemetry is disabled,

Right now the UI state for PPA remains checked and active even when the main telemetry
setting is disabled. This is confusing UX, since DAP submission is disabled when
telemetry is disabled.

Also migrate off the deprecated toolkit-private isTelemetryEnabled() accessor to the normal pref check.

Original Revision: https://phabricator.services.mozilla.com/D216801

Comment 9

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Confusion in settings
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: https://docs.google.com/document/d/1EYNh71lTnoHJ4CDC5nCBT0HbAIjnZowMVqOx12rhdK4/edit
• Risk associated with taking this patch: Low
• Explanation of risk level: This is a relatively straightforward change to settings
• String changes made/needed: No
• Is Android affected?: no

Comment 10

[:Gijs (he/him)]

Attachment: Bug 1908312 - Make it clear in about:preferences that PPA is disabled when telemetry is disabled,

Right now the UI state for PPA remains checked and active even when the main telemetry
setting is disabled. This is confusing UX, since DAP submission is disabled when
telemetry is disabled.

Also migrate off the deprecated toolkit-private isTelemetryEnabled() accessor to the normal pref check.

Original Revision: https://phabricator.services.mozilla.com/D216801

Comment 11

[Phabricator Automation]

release Uplift Approval Request

• User impact if declined: Confusion in settings
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: https://docs.google.com/document/d/1EYNh71lTnoHJ4CDC5nCBT0HbAIjnZowMVqOx12rhdK4/edit
• Risk associated with taking this patch: Low
• Explanation of risk level: This is a relatively straightforward change to settings
• String changes made/needed: no
• Is Android affected?: no

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/69a1c10e4581

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/5a64403f8125

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9413568 [details]
Bug 1908312 - Make it clear in about:preferences that PPA is disabled when telemetry is disabled,

Approved for 128.1esr.

Comment 15

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/d62877663c09

Comment 16

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Verified the fix using Firefox 128.0.2, Firefox 128.1.0esr and Firefox 129.0b6. Tests were performed on MacOS 14.5, Windows 11 and Ubuntu 24.04.

Cc["@mozilla.org/private-attribution;1"].getService(Ci.nsIPrivateAttributionService).wrappedJSObject.isEnabled() returns the correct value according to the checkbox's state.