1908425 - [toolbar redesign] Implement CFR for tablet address bar

Status: RESOLVED FIXED

(Fenix :: Toolbar, task, P1)

Description

[Roger Yang [:royang]]

This is to implement the CFR for the tablet address bar. The request is from :emilyw.
Figma

Comment 1

[Chris Peterson [:cpeterson]]

P3 because we don't need this bug in our current sprint.

Comment 2

[Joe M [:jmahon]]

Scope expectation:

• CFR points to nav arrows (same as on portrait)
• Should point up if the Toolbar is on top; point down if it's on bottom (unlike on Portrait, where nav bar is always on bottom)

Planning poker notes:
--> should be similar to other CFR work
--> review for CFRs took some time because of edge cases (e.g. browser being opened from search)

Comment 3

[[:skhan]]

(In reply to Joe M [:jmahon] from comment #2)

Scope expectation:

• CFR points to nav arrows (same as on portrait)
• Should point up if the Toolbar is on top; point down if it's on bottom (unlike on Portrait, where nav bar is always on bottom)

Planning poker notes:
--> should be similar to other CFR work
--> review for CFRs took some time because of edge cases (e.g. browser being opened from search)

The edge case of browser being opened from search widget won't be applicable here since this CFR is supposed to be shown on browser screen. Whereas searching from search widget always lands us on home screen.

Comment 4

[Chris Peterson [:cpeterson]]

Bumping priority P1 because Tim says he's working on this bug for the current sprint.

Comment 5

[tchoh]

Attachment: Bug 1908425 - Implement CFR for tablet address bar

Comment 6

[tchoh]

Attachment: Bug 1908425 - Add start anchor offset for CFRPopup

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0ae11e7b891
Implement CFR for tablet address bar r=android-reviewers,petru

Comment 8

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/b0ae11e7b891