1909048 - Clean up document frame callback handling.

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[Emilio Cobos Álvarez (:emilio)]

This will make bug 1800882 simpler.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1909048 - Clean-up document frame callback handling. r=aosmond,smaug

This will make bug 1800882 simpler. Ideally we'd follow the spec a lot
more closely to the letter (e.g. per spec we should deal with a document
frame request callback calling something like
window.frames[0].contentWindow.requestAnimationFrame() and running that
in the same tick, but for now this doesn't change behavior.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1909048 - Simplify document frame callback scheduling. r=smaug!

This matches the spec better, and is generally simpler.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07bf5b8c5ba4
Clean-up document frame callback handling. r=aosmond

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/07bf5b8c5ba4

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5b85d2d9b6c
Simplify document frame callback scheduling. r=smaug

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8dba5dbf860c
Re-add annotations for test that intermittently fails due to iframe rAF throttling.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c1395e96f14a
Temporarily disable a test that fails due to bug 1909712.

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e5b85d2d9b6c
https://hg.mozilla.org/mozilla-central/rev/8dba5dbf860c
https://hg.mozilla.org/mozilla-central/rev/c1395e96f14a

Comment 9

[Mayank Bansal]

This seems to regress async sub-tests and improve sync sub-tests on SP3 :

260% regression on Editor-TipTap/Highlight/Async

6% improvement on Editor-TipTap/Highlight/Sync