1909163 - Select option appears in different origin if user manually opens a new tab with the keyboard or the webpage is allowed popups (window.open)

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Hafiizh]

Attachment: bandicam 2024-07-22 14-49-29-358.mp4

after https://bugzilla.mozilla.org/show_bug.cgi?id=1875354 is fixed the select option will close in a new window or new tab but this can be bypassed by pressing ctrl + t (opens a new tab)

steps to reproduce

1. open sf.html
2. click on "click me"
3. press Ctrl + T to new tab

OS: windows 10

Comment 1

[Hafiizh]

Attachment: sf.html

Firefox version : Nightly 130.0a1 (2024-07-21) (64-bit)

Comment 2

[:Gijs (he/him)]

This is trivially fixable by using tabspecific=true on the ContentSelectDropdown element.

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1909163 - mark select dropdown as tabspecific, r?emilio

Comment 4

[Andrew McCreight [:mccr8]]

This doesn't seem that bad to me. The interaction is a bit weird, and I don't see how you are confusing people much by having it on top of the about:new tab page, so the user would have to have a custom page, which of course the attacker can't tell.

Comment 5

[:Gijs (he/him)]

https://hg.mozilla.org/integration/autoland/rev/022b864d080d3dfd99323b4a1c5b85bb041b82ce

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/022b864d080d

Comment 7

[Daniel Veditz [:dveditz]]

Thank you for reporting this variation. As a sec-low bug it does not qualify for our bounty unfortunately

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for ESR128 approval when you get a chance.

Comment 9

[:Gijs (he/him)]

Attachment: Bug 1909163 - mark select dropdown as tabspecific, r?emilio

Original Revision: https://phabricator.services.mozilla.com/D217232

Comment 10

[Phabricator Automation]

esr128 Uplift Approval Request

• User impact if declined: Spoofing/confusion around select popups
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: see comment 0
• Risk associated with taking this patch: low
• Explanation of risk level: single attribute on the select dropdown
• String changes made/needed: no
• Is Android affected?: no

Comment 11

[:Gijs (he/him)]

Comment on attachment 9419867 [details]
Bug 1909163 - mark select dropdown as tabspecific, r?emilio

So digging into this, I'm realizing this patch doesn't actually work.

Comment 12

[:Gijs (he/him)]

Attachment: Bug 1909163 - make select dropdowns more properly tabspecific, r?emilio

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da046994a08d
make select dropdowns more properly tabspecific, r=emilio

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/da046994a08d

Comment 15

[:Gijs (he/him)]

Attachment: Bug 1909163 - make select dropdowns more properly tabspecific, r?emilio

Original Revision: https://phabricator.services.mozilla.com/D219618

Comment 16

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: spoofy select dropdowns
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: see comment 0
• Risk associated with taking this patch: low
• Explanation of risk level: minor changes to select popup attributes
• String changes made/needed: no
• Is Android affected?: no

Comment 17

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/937757ec266b

Comment 18

[Mihai Boldan, Desktop QA [:mboldan]]

I managed to reproduce the issue on Firefox 129.0.2, under Windows 11.
The issue is no longer reproducible on Firefox 130.0b8(treeherder build), or on Firefox 131.0a1.
Tests were performed under Windows 11x64, macOS 10.15 and Ubuntu 22.04.

Comment 19

[:Gijs (he/him)]

Attachment: Bug 1909163 - mark select dropdown as tabspecific,

Original Revision: https://phabricator.services.mozilla.com/D217232

Comment 20

[Phabricator Automation]

esr128 Uplift Approval Request

• User impact if declined: Confusing select dropdowns
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: See earlier comments
• Risk associated with taking this patch: Low
• Explanation of risk level: Minor JS changes, already verified in nightly
• String changes made/needed: No
• Is Android affected?: no

Comment 21

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/d223a49f06ef

Comment 22

[Mihai Boldan, Desktop QA [:mboldan]]

Managed to verify the issue on Firefox 128.2.0ESR on Windows 10 and Windows 11.

Comment 23

[Daniel Veditz [:dveditz]]

The Select Element didn't support showPicker() until bug 1854112