1909343 - (rustc-1.82) Update builders to rustc 1.82

Status: RESOLVED FIXED

(Firefox Build System :: Toolchains, task)

Description

[Mike Hommey [:glandium]]

Release date: October 17

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1909343 - Update builders to rustc 1.82.

The rust-dev toolchain is not updated because 1.82 changed things for
build-std that requires reworking the local patches entirely.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f36338ef1de
Update builders to rustc 1.82. r=firefox-build-system-reviewers,ahochheiden

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing crashes

Backout link: https://hg.mozilla.org/integration/autoland/rev/d45a214dab825bdb25b94438b772f989eaf3d9d1

Push with failures

Failure log -> PROCESS-CRASH | application crashed [@ RefPtr<nsFrameSelection>::operator!] | toolkit/components/satchel/test/test_form_autocomplete_with_list.html

Failure log -> Assertion failure: is_aligned<Arch>(aIsOnTheLeft) (aIsOnTheLeft is aligned), at /builds/worker/checkouts/gecko/dom/media/webaudio/AudioNodeEngineGenericImpl.h:308

Failure log -> ValueError: web_socket_transfer_data raised exception for /receive-many-with-backpressure: PyMemoryView_FromBuffer(): info->buf must not be NULL

Comment 4

[Acasandrei Beatrice (needinfo me)]

(In reply to Pulsebot from comment #2)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f36338ef1de
Update builders to rustc 1.82. r=firefox-build-system-reviewers,ahochheiden

Perfherder has detected a build_metrics performance change which could either be cased by https://hg.mozilla.org/integration/autoland/rev/9f36338ef1de or https://hg.mozilla.org/integration/autoland/rev/4e30cef2e71c.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
19%	build times	linux64-shippable	nightly taskcluster-projects/970387039909/machineTypes/n2-custom-64-131072	4,290.41 -> 3,470.73
5%	build times	osx-shippable	nightly taskcluster-projects/970387039909/machineTypes/c2-standard-16	3,589.91 -> 3,393.56

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 2562

For more information on performance sheriffing please see our FAQ.

Comment 5

[Alex Finder]

(In reply to Sandor Molnar[:smolnar] from comment #3)

Backed out for causing crashes

Backout link: https://hg.mozilla.org/integration/autoland/rev/d45a214dab825bdb25b94438b772f989eaf3d9d1

Push with failures

Failure log -> PROCESS-CRASH | application crashed [@ RefPtr<nsFrameSelection>::operator!] | toolkit/components/satchel/test/test_form_autocomplete_with_list.html

Failure log -> Assertion failure: is_aligned<Arch>(aIsOnTheLeft) (aIsOnTheLeft is aligned), at /builds/worker/checkouts/gecko/dom/media/webaudio/AudioNodeEngineGenericImpl.h:308

Failure log -> ValueError: web_socket_transfer_data raised exception for /receive-many-with-backpressure: PyMemoryView_FromBuffer(): info->buf must not be NULL

Perfherder has detected a browsertime performance change from push d45a214dab825bdb25b94438b772f989eaf3d9d1.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
4%	speedometer3 NewsSite-Nuxt/NavigateToPolitics/Sync	windows11-64-nightlyasrelease-qr	fission webrender	14.32 -> 14.95	Before/After
2%	speedometer3 TodoMVC-jQuery/total	windows11-64-nightlyasrelease-qr	fission webrender	145.60 -> 148.82	Before/After
2%	speedometer3 TodoMVC-JavaScript-ES5/Adding100Items/Sync	windows11-64-nightlyasrelease-qr	fission webrender	24.14 -> 24.64	Before/After

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
7%	speedometer3 Charts-chartjs/Draw scatter/Async	windows11-64-nightlyasrelease-qr	fission webrender	0.61 -> 0.57	Before/After

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 2756

For more information on performance sheriffing please see our FAQ.

Comment 6

[Acasandrei Beatrice (needinfo me)]

(In reply to Sandor Molnar[:smolnar] from comment #3)

Backed out for causing crashes

Backout link: https://hg.mozilla.org/integration/autoland/rev/d45a214dab825bdb25b94438b772f989eaf3d9d1

Push with failures

Failure log -> PROCESS-CRASH | application crashed [@ RefPtr<nsFrameSelection>::operator!] | toolkit/components/satchel/test/test_form_autocomplete_with_list.html

Failure log -> Assertion failure: is_aligned<Arch>(aIsOnTheLeft) (aIsOnTheLeft is aligned), at /builds/worker/checkouts/gecko/dom/media/webaudio/AudioNodeEngineGenericImpl.h:308

Failure log -> ValueError: web_socket_transfer_data raised exception for /receive-many-with-backpressure: PyMemoryView_FromBuffer(): info->buf must not be NULL

Perfherder has detected a build_metrics performance change from push d45a214dab825bdb25b94438b772f989eaf3d9d1.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
5%	build times	osx-shippable	nightly taskcluster-projects/970387039909/machineTypes/c2-standard-16	3,380.45 -> 3,557.90

As author of one of the patches included in that push, we need your help to address this regression.
Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 42368

For more information on performance sheriffing please see our FAQ.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d5063ec12c9
Update builders to rustc 1.82. r=firefox-build-system-reviewers,ahochheiden

Comment 8

[amarc]

Backed out for causing build bustages @ rules.mk

• Backout link
• Push with failures
• Failure Log
• Failure line:

gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:539: ../../../dist/bin/xul.dll] Killed

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be613aced7d5
Update builders to rustc 1.82. r=firefox-build-system-reviewers,ahochheiden

Comment 10

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/be613aced7d5

Comment 11

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/be613aced7d5

Comment 12

[Andrej (:aglavic)]

(In reply to Pulsebot from comment #2)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f36338ef1de
Update builders to rustc 1.82. r=firefox-build-system-reviewers,ahochheiden

FYI baseline changes:

Perfherder has detected a talos performance change from push be613aced7d50e298c0e0e9846174d741102dd0f.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
10%	perf_reftest_singletons svg-text-textLength-1.html	macosx1470-64-shippable	e10s fission stylo webrender	1,333.07 -> 1,466.02
10%	perf_reftest_singletons svg-text-textLength-1.html	macosx1470-64-shippable	e10s fission stylo webrender	1,340.37 -> 1,469.49
3%	pdfpaint issue11230.pdf	windows11-64-shippable-qr	e10s fission stylo webrender	225.90 -> 232.46
3%	rasterflood_gradient	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	1,090.96 -> 1,060.08

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
10%	perf_reftest_singletons bloom-basic.html	linux1804-64-shippable-qr	e10s fission stylo webrender	52.89 -> 47.68
10%	perf_reftest_singletons bloom-basic-2.html	linux1804-64-shippable-qr	e10s fission stylo webrender	52.78 -> 47.67
8%	perf_reftest_singletons style-sharing.html	windows11-64-shippable-qr	e10s fission stylo webrender	3.30 -> 3.04
6%	perf_reftest_singletons style-sharing-style-attr.html	windows11-64-shippable-qr	e10s fission stylo webrender	3.37 -> 3.16
3%	rasterflood_gradient	macosx1470-64-shippable	e10s fission stylo webrender-sw	1,294.43 -> 1,330.58

As author of one of the patches included in that push, we need your help to address this regression.
Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 42970

For more information on performance sheriffing please see our FAQ.