1909544 - Enable the jstracer in the browser toolbox

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement)

Description

[Alexandre Poirot [:ochameau]]

The jstracer can already be toggled in the browser toolbox via the web console command, but the icon is explicitly disabled for the browser toolbox.
There is also a few exceptions when trying to toggle it.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1909544 - [devtools] Fix duplicated session data updates in the browser toolbox.

The workers array on watcher data object is shared between all worker types.
We should be careful to only consider the entries matching the current worker watcher class.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1909544 - [devtools] Enable jstracer in the browser toolbox.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c5e28887e098
[devtools] Fix duplicated session data updates in the browser toolbox. r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/9970146a7696
[devtools] Enable jstracer in the browser toolbox. r=devtools-reviewers,nchevobbe

Comment 4

[tszentpeteri]

Backed out for causing leaks.

• Backout link
• Push with failures
• Failure Log for leak on browser.toml:
• Failure Log for leak on _jsterm.toml:
• Failure Log for leak on _browser_console.toml:

[task 2024-07-24T20:00:18.389Z] 20:00:18    ERROR - GECKO(8396) | ==8396==ERROR: LeakSanitizer: detected memory leaks
[task 2024-07-24T20:00:18.390Z] 20:00:18     INFO - GECKO(8396) | Direct leak of 96 byte(s) in 1 object(s) allocated from:
[task 2024-07-24T20:00:18.411Z] 20:00:18     INFO - GECKO(8396) |     #0 0x560b644c565f in malloc /builds/worker/fetches/llvm-project/compiler-rt/lib/asan/asan_malloc_linux.cpp:68:3
[task 2024-07-24T20:00:18.411Z] 20:00:18     INFO - GECKO(8396) |     #1 0x560b64509f05 in moz_xmalloc /builds/worker/checkouts/gecko/memory/mozalloc/mozalloc.cpp:52:15
[task 2024-07-24T20:00:18.412Z] 20:00:18     INFO - GECKO(8396) |     #2 0x7eff492f3c5a in operator new /builds/worker/workspace/obj-build/dist/include/mozilla/cxxalloc.h:33:10
[task 2024-07-24T20:00:18.413Z] 20:00:18     INFO - GECKO(8396) |     #3 0x7eff492f3c5a in XPCWrappedNative::GetNewOrUsed(JSContext*, xpcObjectHelper&, XPCWrappedNativeScope*, XPCNativeInterface*, XPCWrappedNative**) /builds/worker/checkouts/gecko/js/xpconnect/src/XPCWrappedNative.cpp:424:15
[task 2024-07-24T20:00:18.414Z] 20:00:18     INFO - GECKO(8396) |     #4 0x7eff492875a2 in XPCConvert::NativeInterface2JSObject(JSContext*, JS::MutableHandle<JS::Value>, xpcObjectHelper&, nsID const*, bool, nsresult*) /builds/worker/checkouts/gecko/js/xpconnect/src/XPCConvert.cpp:904:17
[task 2024-07-24T20:00:18.415Z] 20:00:18     INFO - GECKO(8396) |     #5 0x7eff49285af7 in XPCConvert::NativeData2JS(JSContext*, JS::MutableHandle<JS::Value>, void const*, nsXPTType const&, nsID const*, unsigned int, nsresult*) /builds/worker/checkouts/gecko/js/xpconnect/src/XPCConvert.cpp:321:14
[task 2024-07-24T20:00:18.425Z] 20:00:18     INFO - GECKO(8396) |     #6 0x7eff492ed25e in nsXPCWrappedJS::CallMethod(unsigned short, nsXPTMethodInfo const*, nsXPTCMiniVariant*) /builds/worker/checkouts/gecko/js/xpconnect/src/XPCWrappedJSClass.cpp:870:12
[task 2024-07-24T20:00:18.425Z] 20:00:18     INFO - GECKO(8396) |     #7 0x7eff47d4f949 in PrepareAndDispatch /builds/worker/checkouts/gecko/xpcom/reflect/xptcall/md/unix/xptcstubs_x86_64_linux.cpp:115:37
[task 2024-07-24T20:00:18.426Z] 20:00:18     INFO - GECKO(8396) |     #8 0x7eff47d4e7fe in SharedStub xptcstubs_x86_64_linux.cpp
[task 2024-07-24T20:00:18.426Z] 20:00:18     INFO - GECKO(8396) |     #9 0x7eff505466b4 in mozilla::dom::WorkerDebuggerManager::RegisterDebuggerMainThread(mozilla::dom::WorkerPrivate*, bool) /builds/worker/checkouts/gecko/dom/workers/WorkerDebuggerManager.cpp:283:17
[task 2024-07-24T20:00:18.426Z] 20:00:18     INFO - GECKO(8396) |     #10 0x7eff5057a8d2 in RegisterWorkerDebugger /builds/worker/checkouts/gecko/dom/workers/WorkerDebuggerManager.h:93:12
[task 2024-07-24T20:00:18.426Z] 20:00:18     INFO - GECKO(8396) |     #11 0x7eff5057a8d2 in EnableDebugger /builds/worker/checkouts/gecko/dom/workers/WorkerPrivate.cpp:1677:7
[task 2024-07-24T20:00:18.427Z] 20:00:18     INFO - GECKO(8396) |     #12 0x7eff5057a8d2 in mozilla::dom::WorkerPrivate::Constructor(JSContext*, nsTSubstring<char16_t> const&, bool, mozilla::dom::WorkerKind, mozilla::dom::RequestCredentials, mozilla::dom::WorkerType, nsTSubstring<char16_t> const&, nsTSubstring<char> const&, mozilla::dom::WorkerLoadInfo*, mozilla::ErrorResult&, nsTString<char16_t>, std::function<void (bool)>&&, std::function<void ()>&&) /builds/worker/checkouts/gecko/dom/workers/WorkerPrivate.cpp:2784:11
[task 2024-07-24T20:00:18.427Z] 20:00:18     INFO - GECKO(8396) |     #13 0x7eff5051c2f2 in mozilla::dom::ChromeWorker::Constructor(mozilla::dom::GlobalObject const&, nsTSubstring<char16_t> const&, mozilla::dom::WorkerOptions const&, mozilla::ErrorResult&) /builds/worker/checkouts/gecko/dom/workers/ChromeWorker.cpp:33:41
[task 2024-07-24T20:00:18.427Z] 20:00:18     INFO - GECKO(8396) |     #14 0x7eff4c7edfdd in mozilla::dom::ChromeWorker_Binding::_constructor(JSContext*, unsigned int, JS::Value*) /builds/worker/workspace/obj-build/dom/bindings/./WorkerBinding.cpp:332:58
[task 2024-07-24T20:00:18.428Z] 20:00:18     INFO - GECKO(8396) |     #15 0x7eff52ececeb in CallJSNative /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:491:13
[task 2024-07-24T20:00:18.428Z] 20:00:18     INFO - GECKO(8396) |     #16 0x7eff52ececeb in CallJSNativeConstructor /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:507:8
[task 2024-07-24T20:00:18.429Z] 20:00:18     INFO - GECKO(8396) |     #17 0x7eff52ececeb in InternalConstruct(JSContext*, js::AnyConstructArgs const&, js::CallReason) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:713:14
[task 2024-07-24T20:00:18.429Z] 20:00:18     INFO - GECKO(8396) |     #18 0x7eff52ee79b0 in ConstructFromStack /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:760:10
[task 2024-07-24T20:00:18.429Z] 20:00:18     INFO - GECKO(8396) |     #19 0x7eff52ee79b0 in js::Interpret(JSContext*, js::RunState&) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:3334:16
[task 2024-07-24T20:00:18.430Z] 20:00:18     INFO - GECKO(8396) |     #20 0x7eff52ecb1bf in MaybeEnterInterpreterTrampoline /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:405:10
[task 2024-07-24T20:00:18.430Z] 20:00:18     INFO - GECKO(8396) |     #21 0x7eff52ecb1bf in js::RunScript(JSContext*, js::RunState&) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:463:13
[task 2024-07-24T20:00:18.430Z] 20:00:18     INFO - GECKO(8396) |     #22 0x7eff52ecc40a in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:617:13
[task 2024-07-24T20:00:18.430Z] 20:00:18     INFO - GECKO(8396) |     #23 0x7eff52ece19c in InternalCall /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:652:10
[task 2024-07-24T20:00:18.430Z] 20:00:18     INFO - GECKO(8396) |     #24 0x7eff52ece19c in js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:684:8
[task 2024-07-24T20:00:18.430Z] 20:00:18     INFO - GECKO(8396) |     #25 0x7eff5331e53a in js::CallSelfHostedFunction(JSContext*, JS::Handle<js::PropertyName*>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>) /builds/worker/checkouts/gecko/js/src/vm/SelfHosting.cpp:1555:10
[task 2024-07-24T20:00:18.430Z] 20:00:18     INFO - GECKO(8396) |     #26 0x7eff53d9108e in js::jit::InterpretResume(JSContext*, JS::Handle<JSObject*>, JS::Value*, JS::MutableHandle<JS::Value>) /builds/worker/checkouts/gecko/js/src/jit/VMFunctions.cpp:1140:10
[task 2024-07-24T20:00:18.430Z] 20:00:18     INFO - GECKO(8396) |     #27 0x3bc4551b1cae  (<unknown module>)
[task 2024-07-24T20:00:18.430Z] 20:00:18     INFO - GECKO(8396) |     #28 0x3bc4551b89a8  (<unknown module>)
[task 2024-07-24T20:00:18.430Z] 20:00:18     INFO - GECKO(8396) |     #29 0x3bc4551ae4e5  (<unknown module>)
[task 2024-07-24T20:00:18.430Z] 20:00:18     INFO - GECKO(8396) |     #30 0x7eff543263ce in EnterJit /builds/worker/checkouts/gecko/js/src/jit/Jit.cpp:115:5
[task 2024-07-24T20:00:18.430Z] 20:00:18     INFO - GECKO(8396) |     #31 0x7eff543263ce in js::jit::MaybeEnterJit(JSContext*, js::RunState&) /builds/worker/checkouts/gecko/js/src/jit/Jit.cpp:261:10
[task 2024-07-24T20:00:18.430Z] 20:00:18     INFO - GECKO(8396) |     #32 0x7eff52ecaf24 in js::RunScript(JSContext*, js::RunState&) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:453:32
[task 2024-07-24T20:00:18.430Z] 20:00:18     INFO - GECKO(8396) |     #33 0x7eff52ecc40a in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:617:13
[task 2024-07-24T20:00:18.430Z] 20:00:18     INFO - GECKO(8396) |     #34 0x7eff52ece19c in InternalCall /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:652:10
[task 2024-07-24T20:00:18.430Z] 20:00:18     INFO - GECKO(8396) |     #35 0x7eff52ece19c in js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:684:8
[task 2024-07-24T20:00:18.430Z] 20:00:18     INFO - GECKO(8396) |     #36 0x7eff5331e53a in js::CallSelfHostedFunction(JSContext*, JS::Handle<js::PropertyName*>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>) /builds/worker/checkouts/gecko/js/src/vm/SelfHosting.cpp:1555:10
[task 2024-07-24T20:00:18.430Z] 20:00:18     INFO - GECKO(8396) |     #37 0x7eff52fe2a1e in AsyncFunctionResume(JSContext*, JS::Handle<js::AsyncFunctionGeneratorObject*>, ResumeKind, JS::Handle<JS::Value>) /builds/worker/checkouts/gecko/js/src/vm/AsyncFunction.cpp:151:8
[task 2024-07-24T20:00:18.430Z] 20:00:18     INFO - GECKO(8396) |     #38 0x7eff5324a8f2 in AsyncFunctionPromiseReactionJob /builds/worker/checkouts/gecko/js/src/builtin/Promise.cpp:2113:12
[task 2024-07-24T20:00:18.430Z] 20:00:18     INFO - GECKO(8396) |     #39 0x7eff5324a8f2 in PromiseReactionJob(JSContext*, unsigned int, JS::Value*) /builds/worker/checkouts/gecko/js/src/builtin/Promise.cpp:2176:12
[task 2024-07-24T20:00:18.430Z] 20:00:18     INFO - GECKO(8396) |     #40 0x7eff52ecc294 in CallJSNative /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:491:13
[task 2024-07-24T20:00:18.430Z] 20:00:18     INFO - GECKO(8396) |     #41 0x7eff52ecc294 in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:585:12

Comment 5

[Alexandre Poirot [:ochameau]]

The leak should be fixed:
https://treeherder.mozilla.org/jobs?repo=try&selectedTaskRun=Qmjx6-1sRhGpB2tmyEXw7A.0&revision=14e0af8f1aecb3b6e2a1e305eb21424cadc91885

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26969d28574a
[devtools] Fix duplicated session data updates in the browser toolbox. r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/2151d339b778
[devtools] Enable jstracer in the browser toolbox. r=devtools-reviewers,nchevobbe

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/26969d28574a
https://hg.mozilla.org/mozilla-central/rev/2151d339b778