1909621 - Intermittent message table cells corruption when using addons providing custom columns

Status: VERIFIED FIXED

(Thunderbird :: Folder and Message Lists, defect, P1)

Description

[Łukasz]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:128.0) Gecko/20100101 Firefox/128.0

Steps to reproduce:

(based on discussion in https://thunderbird.topicbox.com/groups/addons/Tbf42e54fb268e92c)

1. Install addon which adds new columns to message list, such as Full Address Column or Conversations.
2. Switch message list to table view.
3. Open as many tabs (with messages, settings etc) as possible.
4. Restart Thunderbird with -devtools commandline argument.

Actual results:

Sometimes Thunderbird starts with corrupted message list - table body does not match table header. Internally, table header contains TH elements for original 22 columns, as initialized in ThreadPaneColumns.DEFAULT_COLUMNS, while table body contains 26 columns (22 original + 4 from addon). When inspected by devtools threadPane.columns (from about3Pane.js) contains only 22 columns, but ThreadPaneColumns.DEFAULT_COLUMNS is properly extended to 26 by appending 4 columns registered using ThreadPaneColumns.addCustomColumn.

More details in discussion linked above.

Expected results:

Thunderbird should start normally, with uncorrupted message list, including columns added by addons.

Comment 1

[Łukasz]

Attachment: screenshot-of-message-list-with-tbody.png

Comment 2

[Łukasz]

Attachment: screenshot-of-thead.png

Comment 3

[Mark Banner (:standard8)]

Confirming as I've seen this on Conversations as well, with 128. Requesting tracking as this seems to be quite a severe problem for add-ons that use the new column API.

Comment 4

[Mark Banner (:standard8)]

I had this twice in a row whilst the laptop was under a bit of load & given the nature of the intermittent, it is most likely timing related.

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1909621 - Call addCustomColumn for each custom column when first loading. r=#thunderbird-reviewers

If a custom column definition exists on the first load of the message list, it does not get added
to threadPane.columns, so the column's cell in the template row doesn't get hidden.

Comment 10

[John Bieling (:TbSync)]

Nice! Thanks Geoff.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c0c7740c8355
Call addCustomColumn for each custom column when first loading. r=tobyp

Comment 12

[Geoff Lankow (:darktrojan)]

Comment on attachment 9436764 [details]
Bug 1909621 - Call addCustomColumn for each custom column when first loading. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: add-ons that add columns to the message list fail to load properly in some circumstances, making the message list a mess
Testing completed (on c-c, etc.): landed two days ago
Risk to taking this patch (and alternatives if risky): low

Comment 13

[Corey Bryant]

Comment on attachment 9436764 [details]
Bug 1909621 - Call addCustomColumn for each custom column when first loading. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 14

[Corey Bryant]

Thunderbird 133.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/0ca808413de6

Comment 15

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Confirming this issue as verified fixed using 133.0b5-build2(20241118140457) with macOS 14, Ubuntu 24 and WIndows 11 using the STR from the Description.

Comment 17

[Geoff Lankow (:darktrojan)]

Comment on attachment 9436764 [details]
Bug 1909621 - Call addCustomColumn for each custom column when first loading. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: add-ons that add columns to the message list fail to load properly in some circumstances, making the message list a mess
Testing completed (on c-c, etc.): in 133 beta 5
Risk to taking this patch (and alternatives if risky): low