1909746 - [Toolbar Redesign] The saved login panels that appear because of feature access should appear above the toolbar irrespective of top/bottom placement of toolbar.

Status: VERIFIED FIXED

(Firefox for Android :: Toolbar, task, P3)

Description

[Aarjav [:aarjav]]

Steps to reproduce

1. Go to a website that requires a sign in
2. Click on the username/password fields.

Expected behavior

• The saved passwords panel should always be above the bottom-placed toolbar. An example is shown in the Figma link below.

Actual behavior

• The saved passwords panel is placed below the toolbar.
• This makes the passwords panel less contextual.

Device information

• Firefox version: Nightly
• Android device model: Pixel 6
• Android OS version: Latest

Any additional information?

Figma Link: https://www.figma.com/design/8fsCvtnweBkWGZ9NfL907l/Toolbar-Redesign?node-id=17891-293506&t=ur7cBuPjAOXTzif6-4

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: image.png

@AArjav What's the relation with other dialogs that now appear on top of the toolbar?

• start download
• download complete

Also the find in page bar which now replaces the toolbar.
Which should appear on top?

Also, I see that when the login select bar is expanded the toolbar should be hidden.
Would the other dialogs will remain shown?

Screenshot added for how the current UI.

Comment 2

[Aarjav [:aarjav]]

• The download panels (start + complete) should continue to be shown over the nav bar.
• The find in page should continue to replace the toolbar.
• As we either override or replace the toolbar for the above features, the same behavior of expanded panel will not be seen.

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Checked with Aarjav and the recommended way to avoid the conflict between the downloads panels and the logins ones is:

• when the keyboard is shown
  • show the logins panels above the toolbar - they are needed for the autofill scenario that the user is in
  • hide the downloads panel - it's rather an inconvenience for the autofill scenario
• when the keyboard is hidden
  • hide the logins panels - they are not immediately needed for an autofill scenario
  • show the downloads panel - as part of the normal browsing UX.

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Working on this and trying to use the keyboard status as a way to know when to I see some edgecases which I think prevents us from reliably using this to disambiguate when to hide the downloads panels:

• when the user is interacting with the expanded logins bar - the keyboard is closed but we still need to show the logins bars and not downloads
• when using external keyboard a software one would not be shown on the screen.

We can though use the visibility of the logins bars to know when to hide other panels though this will greatly increase the complexity of the code and add the risk of something potentially breaking.

Comment 5

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1909746 - part 1 - Ensure logins bars are shown on top of the bottom toolbar r=#android-reviewers

Comment 6

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1909746 - part 2 - Rework prompts interfaces r=#android-reviewers

We had two interfaces - SelectablePromptView and PasswordPromptView with very
similar functionality.
Combined the same behavior and extracted the differences into new interfaces with a
more clearer scope.
This is a building block for easily adding more functionality later.

Comment 7

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1909746 - part 3 - Hide bottom toolbar dividers when login bars are shown on top r=#android-reviewers

Comment 8

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1909746 - part 4 - Hide bottom toolbars when the logins bar is expanded r=#android-reviewers

Comment 9

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1909746 - part 5 - Ensure snackbars are shown on top of the logins bars r=#android-reviewers

Comment 10

[Petru-Mugurel Lingurar [:petru]]

Looked into potential approaches to avoid the conflict with the download dialogs.
We could work more to ensure that when download panels appears they should hide these panels
And when these logins panels appear they should hide the download panels
And while one is shown don't hide the other
But this should mean that if a download is finished while the user interacts with logins we should remember to show again the finished downloads after the logins interaction is finished.
This all means brittle code and complexity that I'd prefer to avoid if we know that the download panels will soon be updated.
So waiting to merge up until after that.

Comment 11

[Petru-Mugurel Lingurar [:petru]]

Checked with Aarjav about how to solve the conflict between the download panels and the login panel.
As a new decision: this conflict is just an edgecase and should not be a release blocker -> we should:

• land the work in the current state as the functionality asked in the ticket is already implemented
• create a new ticket (not blocking the toolbar redesign) to re-evaluate how the "download complete" panel should be shown - bug 1933146.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/70989908cf5e
part 1 - Ensure logins bars are shown on top of the bottom toolbar r=android-reviewers,harrisono
https://hg.mozilla.org/integration/autoland/rev/2f0529dba037
part 2 - Rework prompts interfaces r=android-reviewers,harrisono
https://hg.mozilla.org/integration/autoland/rev/8417a84cc2ed
part 3 - Hide bottom toolbar dividers when login bars are shown on top r=android-reviewers,harrisono
https://hg.mozilla.org/integration/autoland/rev/f495a5a8ed52
part 4 - Hide bottom toolbars when the logins bar is expanded r=android-reviewers,harrisono
https://hg.mozilla.org/integration/autoland/rev/1e0ad79f20c3
part 5 - Ensure snackbars are shown on top of the logins bars r=android-reviewers,harrisono

Comment 13

[amarc]

https://hg.mozilla.org/mozilla-central/rev/70989908cf5e
https://hg.mozilla.org/mozilla-central/rev/2f0529dba037
https://hg.mozilla.org/mozilla-central/rev/8417a84cc2ed
https://hg.mozilla.org/mozilla-central/rev/f495a5a8ed52
https://hg.mozilla.org/mozilla-central/rev/1e0ad79f20c3

Comment 14

[Delia Pop (Android QA)]

Attachment: Google Pixel 8 Pro.mp4

Verified as fixed in Nightly 135.0a1 from 12/06 with Google Pixel 8 Pro (Android 14). The "Saved passwords" panel appears above the nav bar and toolbar (when toolbar is set to Bottom).
The toolbars are hidden when the "Saved passwords" panel is expanded.
The only issue noticed is the one mention in the comments above, regarding the conflict with the download dialogue (1933146).

Comment 15

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 9433130 [details]
Bug 1909746 - part 1 - Ensure logins bars are shown on top of the bottom toolbar r=#android-reviewers

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: UX update planned for 134
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Ensure you have login information saved for a particular website
  Access that website's login page
  Tap on the username / password fields
  Verify the UX for the login panels from the bottom of the screen
• List of other uplifts needed: Bug 1935244, Bug 1935429
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): A big patch verified by QA though
• String changes made/needed:
• Is Android affected?: No

Comment 16

[Petru-Mugurel Lingurar [:petru]]

Postponing asking for a beta uplift pending more investigation in bug 1936040.

Comment 17

[Delia Pop (Android QA)]

Hi Petru, are there any updates on this ticket since your last comment?
Could we remove the qe-verify+ label if this does not need QA? Thanks!

Comment 18

[Petru-Mugurel Lingurar [:petru]]

Thanks for the ping.
This got to beta without an uplift so I don't think we necessarily need a new verification.