1910409 - [Toolbar Redesign] The "Select address" and "Use saved cards" prompts should appear above the navigation toolbar/address bar

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, task, P3)

Description

[Delia Pop (Android QA)]

Attachment: Autofill_prompts.png

Steps to reproduce

1. Make sure to have at least one address and a credit card saved.
2. Access a website with an address/credit card form ( e.g. https://checkout.stripe.dev/)
3. Tap on one of the address/credit cards fields.
4. Observe the "Select address" and "Use saved cards" prompts.

Expected behavior

The "Select address" and "Use saved cards" prompts should appear:

• above the navigation toolbar, when the address bar is set to Top;
• above the address bar, when the address bar is set to Bottom;

Actual behavior

The "Select address" and "Use saved cards" prompts appear below the navigation toolbar/address bar

Device information

• Firefox version: Nightly 130.0a1 from 07/29
• Android device model: Google Pixel 8 Pro
• Android OS version: Android 14

Any additional information?

Similar to 1909746

Comment 1

[Chris Peterson [:cpeterson]]

P3 because we don't need this bug in our current sprint.

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Similar to bug 1909746 these panels would conflict with the downloads dialog.
The approach recommended by Aarjav for who to avoid the conflict between the downloads panels and these panels is:

• when the keyboard is shown
  • show the autofill above the toolbar - they are needed for the autofill scenario that the user is in
  • hide the downloads panel - it's rather an inconvenience for the autofill scenario
• when the keyboard is hidden
  • hide the autofill panels - they are not immediately needed for an autofill scenario
  • show the downloads panel - as part of the normal browsing UX.

Comment 3

[Petru-Mugurel Lingurar [:petru]]

The above indications have their own edgecases, part of which I've described here - https://bugzilla.mozilla.org/show_bug.cgi?id=1909746#c4
So we need more investigation on how to resolve the conflict of these panels with the downloads panels.

Comment 4

[Petru-Mugurel Lingurar [:petru]]

(In reply to Petru-Mugurel Lingurar [:petru] from comment #3)

The above indications have their own edgecases, part of which I've described here - https://bugzilla.mozilla.org/show_bug.cgi?id=1909746#c4
So we need more investigation on how to resolve the conflict of these panels with the downloads panels.

Similar to bug 1909746 comment 11 after syncing with Aarjav we should ignore this conflict as just an edgecase which should not be a release blocker so we should implement the change as requested initially.
A followup to redesign the "download complete" panel to avoid this conflict is proposed in bug 1933146.

Comment 5

[[:harrisono]]

Attachment: Bug 1910409 - Move Address and Credit Card autofill banners to above the bottom navigation toolbar. Rename `LoginBarsIntegration` to `AutofillBarsIntegration` Rename `LoginSelectBarBehavior` to `AutofillSelectBarBehavior`

Rename LoginBarsIntegration to AutofillBarsIntegration and associated refactoring.
Rename LoginSelectBarBehavior to AutofillSelectBarBehavior and associated refactoring.
Move Address and Credit Card autofill banners to above the bottom navigation toolbar and add them to AutofillBarsIntegration

Comment 6

[[:harrisono]]

Attachment: Bug 1910409 - Implement ExpandablePrompt interface in AddressSelectBar and CreditCardSelectBar

Comment 7

[[:harrisono]]

Attachment: Bug 1910409 - Move Address and Credit Card autofill banners to above the bottom navigation toolbar. Rename `LoginBarsIntegration` to `AutofillBarsIntegration` Rename `LoginSelectBarBehavior` to `AutofillSelectBarBehavior`

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f66f23f83140
Move Address and Credit Card autofill banners to above the bottom navigation toolbar. Rename `LoginBarsIntegration` to `AutofillBarsIntegration` Rename `LoginSelectBarBehavior` to `AutofillSelectBarBehavior` r=android-reviewers,tchoh,petru
https://hg.mozilla.org/integration/autoland/rev/11adaf02fc9a
Implement ExpandablePrompt interface in AddressSelectBar and CreditCardSelectBar r=android-reviewers,petru

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/f66f23f83140
https://hg.mozilla.org/mozilla-central/rev/11adaf02fc9a