1909933 - Apple Maps compass looks square instead of circle

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

Kinda related to bug 1882178 but I don't have minimal repro for this one.

STR on traditional 96DPI monitor:

0. Get a UA string switcher e.g. https://addons.mozilla.org/en-US/firefox/addon/chrome-mask/.
1. Open https://beta.maps.apple.com
2. Mask as Chrome
3. Go back to https://beta.maps.apple.com (because you'd be in /unsupported path in step 1)
4. See the square compass.
5. Try rotating it (drag by mouse), or control any property in .mw-compass CSS rule in devtools, like top: 81px, width: 37px, border-radius: 49% etc., or zoom the page. It's very sensitive, anything can make it circle.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Standalone test case

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Attachment: Somewhat reduced test case

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Attachment: Mostly reduced test case

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Glenn, this looks like it's probably the same problem as bug 1882178

Comment 5

[Glenn Watson [:gw]]

Reduced wrench test case:

---
root:
  items:
    - type: clip
      id: 2
      complex:
        - rect: [12, 12, 50, 50]
          radius: 27
    - type: stacking-context
      clip-chain: [2]
      items:
      - type: backdrop-filter
        bounds: 12 12 50 50
        filters: invert(1)
      - type: stacking-context
        items:
        - type: rect
          color: red
          bounds: 12 12 50 50

Comment 6

[Teodor Tanasoaia [:teoxoy]]

Should this be closed as duplicate?

Comment 7

[Glenn Watson [:gw]]

No, this is slightly different from that bug, and will require a different fix.

Comment 8

[Glenn Watson [:gw]]

Attachment: Bug 1909933 - Fix backdrop-filter on a transformed + complex clip

Ensure that when we construct a wrapping surface for a transform
due to a complex clip, we mark it as wrapping a backdrop-filter
when that is required.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d344fdf5479
Fix backdrop-filter on a transformed + complex clip r=tnikkel

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/0d344fdf5479