1909986 - For sidebar revamp, only show chatbot entrypoints (context menu, shortcuts) when tools include aichat

Status: RESOLVED FIXED

(Core :: Machine Learning, enhancement, P1)

Description

[Ed Lee :Mardak]

Part of the reason for adding aichat as a tool in bug 1900915 was so people can toggle it closed. But it's still possible to open the chatbot with other entrypoints even when it's not a tool. This should also simplify some experimentation configuration of bug 1895932.

Comment 1

[Sarah Clements [:sclements]]

So you're going to remove use of browser.ml.chat.enabled entirely from browser-sidebar.js? And that's not going to break the configuration of the chatbot in fx labs, it sounds like? And then we'll make the change so that default tools are nimbus pref configurable in bug 1895932. I think lets sequence these changes so there isn't any confusion.

Comment 2

[Ed Lee :Mardak]

This wouldn't touch browser-sidebar.js as this bug is to prevent showing the context menu and shortcuts when revamp doesn't have aichat as a visible tool. I'm thinking something like…

function for showing entrypoint() {
  if (sidebar.revamp && sidebar.main.tools does not includes "aichat") return

Ania says this isn't as needed for 130 as users would need to enable both chatbot and sidebar from labs then customize sidebar to remove chat. This fix should still generally be useful to prevent opening the chatbot if it's not shown in the new sidebar.

Comment 3

[Ed Lee :Mardak]

Attachment: Bug 1909986 - For sidebar revamp, only show chatbot entrypoints (context menu, shortcuts) when tools include aichat r=tarek!

Convert existing entrypoint checks to getter that also checks sidebar.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a38259f7bf5c
For sidebar revamp, only show chatbot entrypoints (context menu, shortcuts) when tools include aichat r=tarek

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/a38259f7bf5c