Closed Bug 1910023 Opened 1 year ago Closed 1 year ago

Fix and re-enable Suggest legacy telemetry tests

Categories

(Firefox :: Address Bar, task, P1)

Product:
Firefox
Component:
Address Bar
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
130 Branch
Tracking Flags:
Tracking Status
firefox130 --- fixed

People

(Reporter: adw, Assigned: adw)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1910023 - Fix and re-enable Suggest legacy telemetry tests.
48 bytes, text/x-phabricator-request
Details | Review

In bug 1869307 Karandeep is modifying the quick suggest provider so it uses the new engagement notification API instead of onLegacyEngagement(). We have a bunch of tests for legacy telemetry that hit this code path. I disabled most of them after we switched to Rust by default, but reviewing his patch made me realize that was a mistake. Legacy engagement and Rust are orthogonal, and we still record legacy engagement even with Rust enabled. We have talked about removing a lot of this telemetry, but until then, I'd like to fix and re-enable these tests so we can verify Karandeep's patch is correct.

Pushed by dwillcoxon@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/90e45ee48da1 Fix and re-enable Suggest legacy telemetry tests. r=daisuke

https://hg.mozilla.org/mozilla-central/rev/90e45ee48da1

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox130: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch
Blocks: 1897244
No longer blocks: 1869307
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: