191036 - Since 1.3a / CVS it is not possible any longer to login with u:admin/p:admin at the above URL. v1.2 or 1.0x works as expected!

Status: RESOLVED DUPLICATE of bug 192170

(Core :: DOM: Core & HTML, defect, P2)

Description

[Marc-Christian Petersen]

User-Agent:       Mozilla/4.80 [en] (X11; U; SunOS 5.9 sun4u)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3b) Gecko/20030128

Since 1.3a / CVS it is not possible any longer to login with u:admin/p:admin at
the above URL (http://www.linux-systeme.de:1028). v1.2 or 1.0x works as expected!
This seems to be platform independant. I tried Mozilla for Windows (2k) and Linux.

Reproducible: Always

Steps to Reproduce:
1. User: admin
2. Password: admin
3. Click login (Anmelden)

Actual Results:  
Nothing happens. It just does nothing where it should login,

Comment 1

[Andrew Schultz]

==> form submission

Comment 2

[Andrew Schultz]

Attachment: testcase

the form has onSubmit="return false;" and the submit button has onClick handler
that submits the form.

Builds before bug 138957 submit the form, but it seems that the new behavior is
correct because of the onSubmit handler.

Comment 3

[Andrew Schultz]

marking NEW, although this appears to be Evang.

Comment 4

[Alexandru Savulov]

awww! awefull complicated testcase. can someone reduce this thing please? i
don't have too  much time available, but i can take a look when a reduced
testcase is available. i fixed bug 138957, that introduced a certain amount of
complexity to the code and i'm interrested in every regression (if regression)
or evangelism issue. 

Comment 5

[Alexandru Savulov]

ah sorry i must be blind :-) i was looking at the URL

Comment 6

[Alexandru Savulov]

here are the related bugs:

bug 138957
bug 147878
bug 180341
bug 183890

hmm, the submit element's onClick returns true so we forget the pending
submission to build a new one but then the form's onSubmit returns false and we
try to only submit pending submissions but there is none. this looks like a bug.
researching.... 

Comment 7

[Alexandru Savulov]

yeah, is our bug. damn. we need to change a bit the way pendig submission get
forgotten. instead of only forgeting them when an onClick handler returns true,
we should forget the pendnig and force the creation of a new one, this time with
the name/value pair of the submitting element (maybe also force the submission).

Comment 8

[Olivier Cahagne]

same testcase, eventhough this bug report is older, I think it's dupe of the
latter as it has patch and the whole discussion.
Please reopen if I'm wrong. :)

*** This bug has been marked as a duplicate of 192170 ***