Closed Bug 1910360 Opened 2 months ago Closed 2 months ago

Use quinn-udp instead of NSPR for QUIC I/O on Nightly

Categories

(Core :: Networking, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
130 Branch
Tracking Status
firefox130 --- fixed

People

(Reporter: mail, Assigned: mail)

References

(Blocks 1 open bug, Regressed 1 open bug)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

https://phabricator.services.mozilla.com/D212959 adds optional support for QUIC
I/O via quinn-udp instead of NSPR. This is controlled via pref
network.http.http3.use_nspr_for_io. The default pref value was true, thus
not using quinn-udp, but NSPR as before.

This commit enables the use of quinn-udp on Firefox Nightly.

Assignee: nobody → mail
Status: NEW → ASSIGNED
Pushed by kjang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e95ff11012c5 use quinn-udp instead of NSPR for QUIC I/O on Nightly r=kershaw
Severity: -- → S3
Priority: -- → P2
Whiteboard: [necko-triaged]
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch
Regressions: 1910594
Backout by sstanca@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/c756f74154bf Backed out changeset e95ff11012c5 as requested for causing Android startup crashes. a=backout
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: 130 Branch → ---

Summary from bug 1910594

  • Prior to publishing, we sanity check [Fenix/Focus] startup Nightly on [ARMv64v8a/x86] on a mix of physical and emulated devices
  • x86 Nightly Android startup was crashing with this preference enabled w/ seccomp prevented call to disallowed x86 system call 337
  • Unfortunately I don't have symbolicated crash-stacks
  • This should be reproducible on installing affected APKs (CI link) on an x86 emulator image on an x86 host and launching Fenix

Thank you Serban, Ryan and Aaron for the investigation and sorry for the trouble. I will take a look tomorrow.

Seems like recvmmsg is by default blocked by seccomp on Android x86.

Tracking this issue upstream on https://github.com/quinn-rs/quinn/issues/1947.

Pushed by kjang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c38029641964 use quinn-udp instead of NSPR for QUIC I/O on Nightly r=kershaw
Status: REOPENED → RESOLVED
Closed: 2 months ago2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch
Regressions: 1911658
See Also: → 1916412
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: