1916412 - Fix Android x86 recvmmsg seccomp failure

Status: RESOLVED FIXED

(Core :: Networking, defect, P3)

Description

[Max Inden]

https://bugzilla.mozilla.org/show_bug.cgi?id=1910360 replaced NSPR with quinn-udp for HTTP3 QUIC UDP IO on Firefox Nightly.

Calls to recvmmsg were prohibited by seccomp on Android x86. See https://bugzilla.mozilla.org/show_bug.cgi?id=1910594.

Upstream quinn-udp tracking issue: https://github.com/quinn-rs/quinn/issues/1947

Upstream quinn-udp fix: https://github.com/quinn-rs/quinn/pull/1966

Now that upstream fix is merged and released, we should upgrade to quinn-udp v0.5.5 and then use quinn-udp on Android x86 on Nightly as well.

modified   modules/libpref/init/StaticPrefList.yaml
@@ -13695,14 +13695,7 @@
 # Use NSPR for HTTP3 UDP IO
 - name: network.http.http3.use_nspr_for_io
   type: RelaxedAtomicBool
-# Always use NSPR on Android x86. On Android x86 sendmsg and recvmmsg, both used
-# by quinn-udp, are disallowed by seccomp. Future fix and further details
-# tracked in https://github.com/quinn-rs/quinn/issues/1947.
-#if defined(ANDROID) && !defined(HAVE_64BIT_BUILD)
-  value: true
-#else
   value: @IS_NOT_NIGHTLY_BUILD@
-#endif
   mirror: always

I will follow-up with a patch.

Comment 1

[Max Inden]

Attachment: Bug 1916412 - fix Android x86 recvmmsg seccomp failure r=jesup,kershaw

https://bugzilla.mozilla.org/show_bug.cgi?id=1910360 replaced NSPR with
quinn-udp for HTTP3 QUIC UDP IO on Firefox Nightly. Calls to recvmmsg were
prohibited by seccomp on Android x86. See
https://bugzilla.mozilla.org/show_bug.cgi?id=1910594, upstream quinn-udp
tracking issue: https://github.com/quinn-rs/quinn/issues/1947 and upstream
quinn-udp fix: https://github.com/quinn-rs/quinn/pull/1966

Now that the upstream fix is merged and released, this commit upgrads neqo_glue
to use quinn-udp v0.5.5. In addition, given the fix, quinn-udp can now be used
on Android x86 Firefox Nightly. Thus this commit also removes the conditional
around the network.http.http3.use_nspr_for_io pref.

Comment 2

[Max Inden]

This Bug is currently blocked on upgrading mozilla-central to windows-sys v0.59.0.

phabricator#D220890 upgrades neqo_glue to use quinn-udp v0.5.5.

quinn-udp v0.5.5 uses windows-sys v0.59.0. All other crates in mozilla-central, 13 in total, use windows-sys v0.52.0. See each linked in this SearchFox search.

If I understand the Mozilla policy on duplicate crate versions correctly, one should strive for a single version of each crate in mozilla-central only. This makes sense to me.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/768c0cdc9453
fix Android x86 recvmmsg seccomp failure r=glandium,supply-chain-reviewers,sunil

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/768c0cdc9453