1910470 - Augment the FOG C++ API's Glean Interface For Firefox Telemetry (GIFFT) to support the Legacy Telemetry event `value` parameter

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P1)

Description

[Chris H-C :chutten]

When we added support for mapping a value-named extra key in the Glean API to the value parameter in the Legacy Telemetry event recording API, we only supported the JS API. We have a few users of the Legacy Telemetry event API in C++ that we should also support.

Comment 1

[Chris H-C :chutten]

Attachment: Bug 1910470 - Support value extra GIFFT mapping in Glean C++ API r?TravisLong!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d92bb998701
Support value extra GIFFT mapping in Glean C++ API r=TravisLong

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing Gtest failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/0901a4733e77b9e7dcbad2eaa02ba71684ce513d

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | TelemetryTestFixture.GIFFTValue | Value of: recordLength == 5

TEST-START | TelemetryTestFixture.GIFFTValue
[task 2024-07-29T21:58:49.529Z] 21:58:49  WARNING -  TEST-UNEXPECTED-FAIL | TelemetryTestFixture.GIFFTValue | Value of: recordLength == 5
[task 2024-07-29T21:58:49.531Z] 21:58:49     INFO -    Actual: false
[task 2024-07-29T21:58:49.531Z] 21:58:49     INFO -  Expected: true
[task 2024-07-29T21:58:49.531Z] 21:58:49     INFO -  Event record must have 5 elements.
[task 2024-07-29T21:58:49.531Z] 21:58:49     INFO -   @ /builds/worker/checkouts/gecko/toolkit/components/telemetry/tests/gtest/TestEvents.cpp:164
[task 2024-07-29T21:58:49.532Z] 21:58:49  WARNING -  TEST-UNEXPECTED-FAIL | TelemetryTestFixture.GIFFTValue | test completed (time: 13ms)
[task 2024-07-29T21:58:49.532Z] 21:58:49     INFO -  TEST-START | TelemetryTestFixture.AccumulateCountHistogram

Comment 4

[Chris H-C :chutten]

So it kinda/sorta depends on the contents whether or not there's five or six items returned in the event record. It's not a very helpful API in that respect.

I've adjusted the test so it ought to always be six.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d08c7ee15b0a
Support value extra GIFFT mapping in Glean C++ API r=TravisLong

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/d08c7ee15b0a