1910581 - Context menu doesn't respect the add-on permissions/prefs

Status: RESOLVED FIXED

(Firefox :: Sidebar, defect, P2)

Description

[William Durand [:willdurand]]

Yet another extension context menu has been implemented in Bug 1893505 but it doesn't respect the add-on permissions/preferences. Some add-ons cannot be removed (e.g. enterprise policies) and some add-ons cannot be reported (because the feature is pref'ed off).

The context menu should be adjusted accordingly, similar to what's been done here: https://searchfox.org/mozilla-central/rev/e637cd67f98ed4272d13a96db9a7674689122dcb/browser/base/content/browser.js#5485,5500-5502 - Otherwise this new sidebar context menu is inconsistent with the other menus for extensions.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:sclements, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:sclements, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1910581 - Context menu doesn't respect the add-on permissions/prefs. r=#sidebar-reviewers!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47cd2b9ca600
Context menu doesn't respect the add-on permissions/prefs. r=sidebar-reviewers,nsharpley

Comment 5

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/47cd2b9ca600