Closed Bug 1910604 Opened 3 months ago Closed 3 months ago

The “Translate Selection to <language>” option is displayed after using the Full Page Translation option

Categories

(Firefox :: Translations, defect)

Desktop
All
defect

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox128 --- unaffected
firefox129 --- unaffected
firefox130 --- affected

People

(Reporter: avarro, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

[Affected versions]:

  • Firefox build version: Firefox Nightly 130.0a1, Build ID: 20240728214119

[Affected Platforms]:

  • Windows 10 x64;
  • macOS 14.5;
  • Ubuntu 22.04.

[Prerequisites]:

  • Have the Firefox build installed.
  • Have the “browser.translations.select.enable” and “browser.translations.enable” prefs set to true on the “about:config” page

[Steps to reproduce]:

  1. Open a webpage that is displayed in a different language than the browser.
  2. Use the Full Page Translation to translate the entire page to a language different than the browser's (and supported by the feature).
  3. Select a string of text and right-click on it.

[Expected result]:

  • The "Translate selection to (browser language)" option is not available.

[Actual result]:

  • The "Translate selection to (browser language)" option is available.

[Notes]:

  • This issue is not reproducible using Firefox Beta 129 and Firefox Release 128.
  • We believe that this issue represents a regression and we will perform a regression window as soon as possible.
  • This issue is also reproducible while being enrolled in an experiment with the “selectTranslation” feature configuration.
  • The "Translate selection to (browser language)" option is also displayed if the webpage is displayed in the same language as the browser’s language.
  • Attaching a screenshot of the issue.

Hi Alice,

I don't think that this is a regression, rather the latest improvement to the feature post initial release: Bug 1904355

Can you double check and update the bug accordingly?

Flags: needinfo?(avarro)

Hey, Erik!
Thank you for answering so quickly!
You are right, this is not a regression and it is a part of the latest improvement you just linked.
As for the scenario where the "Translate selection to (browser language)" option is displayed if the webpage is displayed in the same language as the browser’s language could you please tell me if it is also intended?
Thank you!

Flags: needinfo?(avarro) → needinfo?(enordin)

As for the scenario where the "Translate selection to (browser language)" option is displayed if the webpage is displayed in the same language as the browser’s language could you please tell me if it is also intended?

This is intended. The user's primary languages will always be used as a final fallback.

An earlier still-in-progress implementation of the Select Translations Panel opened up to a "Choose language" option in the dropdown menu selector, but the UX recommendation was to never do that and instead allow same-language to same-language translations, which was implemented in Bug 1890404.

As such, it is expected behavior to be able to open the panel to an English-to-English or Spanish-to-Spanish translation, which just allows the original source text to pass through unaltered.

I am currently working on a feature (Bug 1866827) that will allow Firefox to remember the most recently translated-into target languages. This means that even if a user's primary language settings are in English, but they have recently chosen to translate into Spanish, then Spanish is the language that will be offered to them as a target language the next time they attempt to translate something.

I expect these changes to improve the user experience in this regard.

Flags: needinfo?(enordin)

Thank you for the information provided, Erik!
In this case I'll close this Bugzilla ticket since the scenarios are intended.

Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: