1910665 - Enable trending suggestions for all locales on ESR128

Status: VERIFIED FIXED

(Firefox :: Address Bar, enhancement)

Description

[Ryan VanderMeulen [:RyanVM]]

Per bug 1910639, it would be nice to re-enable trending suggestions for all locales on ESR128 as was originally intended for the 128 release prior to the discovery of bug 1906103.

This would entail:

• Backporting bug 1906103.
• Reverting bug 1906192.
• Updating l10n-changesets.json to something more recent to pick up localizations of the new strings.

We're about to ship 128.1esr alongside Fx129 next week, so I'm setting this to tracking for the 128.2esr release shipping with Fx130 on September 3. This will also give us time to monitor the worldwide rollout of the feature in Fx129 and localization progress to make sure there's no unexpected problems there.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1910665 - Enable trending suggestions for all locales on ESR128.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Try push: https://treeherder.mozilla.org/jobs?repo=try&revision=320f861565326918b74226e4a510eafd9288815d

Dale, I'm leaving setting the Uplift Request form in Phabricator for you. Please do so if you're OK with this landing.

Comment 3

[Phabricator Automation]

esr128 Uplift Approval Request

• User impact if declined: ESR users missing feature
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Test that trending suggestions are available on ESR128
• Risk associated with taking this patch: Minimal
• Explanation of risk level: Code has been available on nightly and release for some time
• String changes made/needed: Backported translations included in change
• Is Android affected?: no

Comment 4

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/4298182958af

Comment 5

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Enhancement is implemented on Firefox ESR 128.2.0 on Windows 10, Ubuntu 22, macOS 14.
Trending suggestions are available in the address bar.
Tests were performed on de , it, fr, pt-PT, ro, pl and th locales.