1911100 - Display "Set as default Browser" native prompt in home fragment

Status: VERIFIED FIXED

(Firefox for Android :: Experimentation and Telemetry, task, P1)

Description

[Vlad Dreghici [:vdreghici]]

According to current criteria, the prompt will be displayed when the user lands on the home fragment.

Comment 1

[:Gela]

Attachment: Bug 1911100 - Display Set as default Browser native prompt in home fragment

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f45161fbd89f
Display Set as default Browser native prompt in home fragment r=android-reviewers,vdreghici,rebecatudor273,twhite

Comment 3

[Norisz Fay [:noriszfay]]

Backed out for causing HomeFragmentTest related fenix failure

Backout link

Push with failures

Failure log

This is also failing: https://treeherder.mozilla.org/logviewer?job_id=472773241&repo=autoland&lineNumber=3225

Comment 4

[Aaron Train [:aaronmt]]

This also breaks org.mozilla.fenix.ui.HomeScreenTest#addPrivateBrowsingShortcutFromHomeScreenCFRTest as the default browser prompt pop-ups on the private browsing screen blocking interactions of the test. Not sure if this is the new behaviour but the prompt should be disabled for UI tests (cc @andi).

Comment 5

[Andrei Jolțan [:Andi]]

Yes, we don't display the onboarding for this UI test and it looks like when we switch back the second time to the private browsing home screen the "Set as default browsing" dialog is being displayed.

Not sure if this should happen if the onboarding is being skipped by default ?

Comment 6

[Andrei Jolțan [:Andi]]

Managed to fix the failing UI test yesterday with D221038

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc46c4e2586a
Display Set as default Browser native prompt in home fragment r=android-reviewers,vdreghici,rebecatudor273,twhite

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/dc46c4e2586a

Comment 9

[:Gela]

removing the needinfo label

Comment 10

[:Gela]

Attachment: Bug 1911100 - Display Set as default Browser native prompt in home fragment

Original Revision: https://phabricator.services.mozilla.com/D220189

Comment 11

[Phabricator Automation]

release Uplift Approval Request

• User impact if declined: The native default browser feature will not be accessible in a 131 dot release
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: On Android 10 or newer after the 4th cold start we should see a default prompt asking users if they want to set Firefox as their default browser. On devices with older than Android 10, the behavior remains unchanged and they get a CFR instead.
• Risk associated with taking this patch: Low
• Explanation of risk level: Does not impact existing functionality drastically. Users on Android 10+ get a native prompt to set Firefox as their default browser.
• String changes made/needed: No
• Is Android affected?: yes

Comment 12

[Andrei Jolțan [:Andi]]

As Ryan suggested, I've added Bug 1916749 to the depends on field as these changes will break the UI tests.

Requested an uplift D223604 to land them at the same time.

Comment 13

[Mira Lobontiu (Android QA)]

Hello Gela and Aaron,

I tried this scenario on Android 10+ devices, in order to trigger the default prompt:

1. Installed the Fenix Nightly 132.0a1 from Play Store (9/25 build).
2. The "Set Firefox Nightly as your default browser app?" prompt was displayed over the onboarding.
3. Tapped outside it, in order to dismiss it.
4. Dismissed the onboarding, opened a tab.
5. Force closed Fenix.
6. Open a new tab, and force close Fenix 5 five more times.
7. From the device's settings, moved the date & time with 3 weeks ahead.
8. Reopened Fenix.
9. No prompt displayed.
10. Forced from the Secret Settings, by enabling "Enable Native Default Browser Promp for Existing Users" --> the prompt is displayed.

Tested this on a Google Pixel 6 (Android 15), Oppo Find N2 Flip (Android 14), and Xiaomi Mi8 Lite (Android 10).

On the Android <10, on Samsung Galaxy Note 8 (Android 9), and on a HTC 10 (Android 8), it works as expected:

1. Installed the Fenix Nightly 132.0a1 from Play Store (9/25 build).
2. Tapped on "Not now" on the "Set as your default browser" onboarding card.
3. Dismissed the other onboarding cards, opened a tab.
4. Force closed Fenix.
5. Open a new tab, and force close three more times.

The "Set as default browser" banner is displayed on the homescreen.

Please let me know if I'm doing something wrong on trying to retrigger the "Set as default" propmt on Android 10+ devices.

Comment 14

[Aaron Train [:aaronmt]]

Hi miralobontiu; I'll pass it over to Gela on this as I'm not familiar with the proposed changes.

Comment 15

[:Gela]

Please let me know if I'm doing something wrong on trying to retrigger the "Set as default" propmt on Android 10+ devices.

Thanks for testing this, this feature was disabled by default and only becomes available after toggling it on in the secret settings menu. Rebeca just put up a patch to enable this by default which should go in as soon as mach try job succeeds: https://phabricator.services.mozilla.com/D224767

Comment 16

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/da53cbc21573

Comment 17

[Lorand Janos]

Set as browser banner is correctly displayed on the latest Beta (132.0b4) and latest RC (131.0.1) builds on a Android <10 device (Samsung Galaxy Tab S3 with Android 9).

Set as browser prompt is correctly displayed on the latest RC (131.0.1) and on the latest Beta (132.0b4) builds on an Android 14 device (Samsung Galaxy S23 Ultra) through the above mentioned setting.

Marking the ticket as verified on 131 and 132.