1911237 - Flickering on a Codepen canvas demo (https://codepen.io/cantelope/full/GRbjzGO)

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Mayank Bansal]

Go to https://codepen.io/cantelope/full/GRbjzGO
Once the page loads, click "GO" in the demo-apne
The demo will start
Maybe move the mouse inside the demo

AR: The whole demo flickers
ER: Not so
Repros with both gpu-canvas and d2d-canvas

Bisection:
Bug 1889275 - Prevent to call GPUVideoImage::GetAsSourceSurface() in CanvasRenderingContext2D::DrawImage() for SurfaceDescriptorD3D10 if CanvasTranslator is used r=gfx-reviewers,lsalzman
Differential Revision: https://phabricator.services.mozilla.com/D206446

Comment 1

[Mayank Bansal]

Attachment: about:support

Comment 2

[Mayank Bansal]

Profile with graphics preset logging: https://share.firefox.dev/3LL9Gfc

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1889275

:sotaro, since you are the author of the regressor, bug 1889275, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 4

[Sotaro Ikeda [:sotaro]]

I tested with PC with NVIDIA GPU and with 3 PCs with Intel GPUs with nightly. I confirmed the problem with 2 PCs with Intel GPU.

Zero copy video is enabled until early beta with AMD GPUs by Bug 1899450 and Bug 1910990 disables video rendering optimization when Zero copy video is disabled with AMD GPUs. Then it seems not affect to late beta and release with AMD GPUs.

Comment 5

[Mayank Bansal]

If I set media.wmf.zero-copy-nv12-textures = False, I dont repro on Nightly.

Comment 6

[Sotaro Ikeda [:sotaro]]

(In reply to Mayank Bansal from comment #5)

If I set media.wmf.zero-copy-nv12-textures = False, I dont repro on Nightly.

Thank you for checking!

Comment 7

[Sotaro Ikeda [:sotaro]]

I tested more with Win PCs. Rendering problem happened with more PCs.
-[1] Win10 PC with Intel GPU(zero copy video): flickering happened
-[2] Win11 PC with Intel Gen12 GPU(REUSE_DECODER_DEVICE blocked by Bug 1896823): flickering happened
-[3] Win11 PC with NVIDIA GPU: flickering happened with pref media.wmf.zero-copy-nv12-textures = false

For some reason [3], the problem was solved by using the original ID3D11Texture2D instead of the ID3D11Texture2D opened with the shared handle. Then the cause of each flicker could be different.

I do not have PC with AMD GPU, I am going to get one soon.

Comment 8

[Sotaro Ikeda [:sotaro]]

From comment 5 and comment 7, it seems better to disable the video rendering optimization with ID3D11Texture2D for now. Though it causes huge performance regression.

Comment 9

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1911237 - Disable SurfaceDescriptorD3D10 fast path of CanvasRenderingContext2D::DrawImage() with remote Canvas2d

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1889275

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/69ee4d33c134
Disable  SurfaceDescriptorD3D10 fast path of CanvasRenderingContext2D::DrawImage() with remote Canvas2d r=gfx-reviewers,lsalzman

Comment 12

[Sotaro Ikeda [:sotaro]]

Bug 1911937 is created for re-enabling SurfaceDescriptorD3D10 fast path of CanvasRenderingContext2D::DrawImage() with remote Canvas2d.

Comment 13

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/69ee4d33c134

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:sotaro, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox130 to wontfix.

For more information, please visit BugBot documentation.

Comment 15

[Donal Meehan [:dmeehan]]

Adding to Comment 14, please consider also adding a release uplift request.
We could consider including this in the planned Fx129 dot release.

Comment 16

[Mayank Bansal]

This is fixed for me on the latest Nightly. Profile for reference: https://share.firefox.dev/3SEFDtu / https://share.firefox.dev/3LXUSKe

Comment 17

[Sotaro Ikeda [:sotaro]]

Comment on attachment 9417905 [details]
Bug 1911237 - Disable SurfaceDescriptorD3D10 fast path of CanvasRenderingContext2D::DrawImage() with remote Canvas2d

Beta/Release Uplift Approval Request

• User impact if declined: The flickering happens with STR of Bug 1911237 with Intel GPUs, NVIDIA GPUs and AMD GPUs.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This change is a fallback to an older, slower implementation that has been in use for a long time.
• String changes made/needed: no
• Is Android affected?: No

Comment 18

[Donal Meehan [:dmeehan]]

Comment on attachment 9417905 [details]
Bug 1911237 - Disable SurfaceDescriptorD3D10 fast path of CanvasRenderingContext2D::DrawImage() with remote Canvas2d

Approved for 130.0b3

Comment 19

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/4892b6e6c4b6

Comment 20

[Donal Meehan [:dmeehan]]

Comment on attachment 9417905 [details]
Bug 1911237 - Disable SurfaceDescriptorD3D10 fast path of CanvasRenderingContext2D::DrawImage() with remote Canvas2d

Approved for 129.0.2

Comment 21

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/7e3126a7ed01