1896823 - Block reusing decoder device on Intel gen12

Status: RESOLVED FIXED

(Core :: Graphics, task)

Description

[Sotaro Ikeda [:sotaro OOO until July/21]]

With Intel Gen12, WMF hardware decoder performance becomes worse with reusing decoder device. Until Bug 1893427 is addressed, it seems necessary to block reusing decoder device on Intel gen12.

Comment 1

[Sotaro Ikeda [:sotaro OOO until July/21]]

Attachment: Bug 1896823 - Block reusing decoder device on Intel gen12

Comment 2

[Sotaro Ikeda [:sotaro OOO until July/21]]

list of Intel Gen12 GPUs are from ANGLE
https://searchfox.org/mozilla-central/rev/7a8904165618818f73ab7fc692ace4a57ecd38c9/gfx/angle/checkout/src/libANGLE/renderer/driver_utils.cpp#125

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/30131f0c7ff8
Block reusing decoder device on Intel gen12 r=gfx-reviewers,bradwerth

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/30131f0c7ff8

Comment 5

[Sotaro Ikeda [:sotaro OOO until July/21]]

Comment on attachment 9401831 [details]
Bug 1896823 - Block reusing decoder device on Intel gen12

Beta/Release Uplift Approval Request

• User impact if declined: Hardware video decoding becomes gradually slow down during several video plays like Bug 1890622.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change adds blocking REUSE_DECODER_DEVICE on Intel Gen12 GPUs. The config is already used by gecko.
• String changes made/needed: none
• Is Android affected?: No

Comment 6

[Pascal Chevrel:pascalc]

Comment on attachment 9401831 [details]
Bug 1896823 - Block reusing decoder device on Intel gen12

Approved for 127 beta 4, thanks.

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/afd180bb13a3

Comment 8

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/afd180bb13a3