1911748 - Chatbot: too much insistent -> shortcuts Icon every where ( when using the touchpad )

Status: VERIFIED FIXED

(Core :: Machine Learning, defect)

Description

[[:FredM]]

Attachment: Capture d'écran 2024-08-06 114109.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:131.0) Gecko/20100101 Firefox/131.0

Steps to reproduce:

On the today nightly build firefox / windows 11. 131.0a1 (2024-08-05) (64 bits)

It s annoying
On every site, click left any where, if there is the icon LeChat

Comment 1

[Francesco Lodolo [:flod]]

I've seen the icon persist on a new tab also with ChatGPT, but can't reproduce consistently.

Comment 2

[Ed Lee :Mardak]

The current shortcuts behavior in nightly 131 with bug 1911173 is to show the icon after selecting some text, and it goes away when scrolling the page or deselecting since the original bug 1905750. The icon does stay when switching back to the original tab, but opening a new tab shouldn't have the icon shown.

In the meantime, you can go to about:preferences#experimental and uncheck "Show prompts on text select"

Comment 3

[[:FredM]]

But I click anywhere, without selecting a text.
And this is appearing :

Comment 4

[[:FredM]]

Attachment: Capture d'écran 2024-08-06 190017_v2.png

Comment 5

[[:FredM]]

The icon was not present yesterday.

Comment 6

[Ed Lee :Mardak]

Ah yes, a change with bug 1911173 is to also show it on a long press. Are your usual clicks always showing it or only if you press and hold the click? It is a short 200ms timer though (i.e., shorter than 200ms between mousedown to mouseup should not show the shortcuts).

Comment 7

[Ed Lee :Mardak]

Oh interesting. I also see the icon appear when I click in bugzilla on a name to see the in-page popup (Profile, Copy Name, Activity…) then clicking away. Seems like there's something wrong with the time check.

Comment 8

[[:FredM]]

You are right, the issue is specific to the touchpad of the laptop

It doesn't appear with the mouse

Comment 9

[Ed Lee :Mardak]

Attachment: Bug 1911748 - Chatbot: too much insistent -> shortcuts Icon every where ( when using the touchpad ) r=tarek!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16c6fd55aeb9
Chatbot: too much insistent -> shortcuts Icon every where ( when using the touchpad ) r=tarek

Comment 11

[Ed Lee :Mardak]

The patch is turning off the long-press behavior for now as we don't really have selection-less prompts yet, and in addition to OP's trackpad clicks appearing longer and scrollbar drags, this is also causing accidental shortcuts for situations where we're currently unable to get the selection, e.g., google docs/slides, input/textarea

Comment 12

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/16c6fd55aeb9

Comment 13

[Ed Lee :Mardak]

[Tracking Requested - why for this release]: Uplifting bug 1911173 can show the shortcuts too frequently with clicks without a selection

Comment 14

[[:FredM]]

It is now working fine.
Thank you for the quick fix,

I have opened several other Bugzilla tickets related to 'Firefox / Android smartphone.'
Could you please take a look at them and consider raising their priority internally?

Behaviour :
Bug 1909495 Give option to change duration of exit fullscreen snackbar
Bug 1911418 Behaviour private windows after leave and enter again

New Feature :
Bug 1906402 Android OneDrive support for my download path
Bug 1906401 Missing PIP shortcut

Your attention to these matters would be greatly appreciated.

Comment 15

[Ed Lee :Mardak]

Attachment: Bug 1911748 - Chatbot: too much insistent -> shortcuts Icon every where ( when using the touchpad )

Allow the long press delay to be pref controlled with a higher default 200ms -> 60s effectively turning it off. Record the delay with glean.

Original Revision: https://phabricator.services.mozilla.com/D218662

Depends on D218869

Comment 16

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: optional chatbot shortcuts can appear more frequently than desired
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: enable chatbot with provider from labs, trigger shortcuts, e.g., select text
• Risk associated with taking this patch: low
• Explanation of risk level: default off behind firefox labs checkboxes with shortcuts depending on users to select text
• String changes made/needed: no
• Is Android affected?: no

Comment 17

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/f3bedd4466e7

Comment 18

[Rares Doghi, Desktop QA]

Updating the remaining flags for our latest Nightly build as well as Beta 130.0b3. This issue is verified as fixed.