1911888 - if text selected somewhere on page and a link clicked with middle mouse button/mousewheel (to open it in a new tab), generative AI popup button gets shown but shouldn't

Status: VERIFIED FIXED

(Core :: Machine Learning, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Firefox 131.0a1 20240805215935 on Windows 10

If there is text selected somewhere on the page and a link gets clicked with the middle mouse button/mousewheel to open it in a new tab, a new tab gets opened but also a generative AI popup button gets shown but shouldn't.

Comment 1

[Ed Lee :Mardak]

Perhaps we should ignore any modified non-primary mouse clicks, e.g., ignore when shift or other buttons?

Comment 2

[Ed Lee :Mardak]

The no selected text is handled as a long click for potentially supporting upcoming selection-less prompts, e.g., summarize page. The delay for determining it's a long click is getting bumped up from 200ms to 500ms with bug 1911748.

Comment 3

[Ed Lee :Mardak]

Attachment: Bug 1911888 - if text selected somewhere on page and a link clicked with middle mouse button/mousewheel (to open it in a new tab), generative AI popup button gets shown but shouldn't r=tarek!

Ignore modified clicks to only support plain clicks.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6969dc91e754
if text selected somewhere on page and a link clicked with middle mouse button/mousewheel (to open it in a new tab), generative AI popup button gets shown but shouldn't r=tarek

Comment 5

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/6969dc91e754

Comment 6

[Ed Lee :Mardak]

[Tracking Requested - why for this release]: Uplifting bug 1911173 can show the shortcuts too frequently on other types of mouse clicks

Comment 7

[Rares Doghi, Desktop QA]

This issue is Verified as fixed in our latest Nightly build 131.0a1 (2024-08-08)

Comment 8

[Ed Lee :Mardak]

Attachment: Bug 1911888 - if text selected somewhere on page and a link clicked with middle mouse button/mousewheel (to open it in a new tab), generative AI popup button gets shown but shouldn't

Ignore modified clicks to only support plain clicks.

Original Revision: https://phabricator.services.mozilla.com/D218672

Depends on D218868

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/4b0283c342db

Comment 10

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Beta 130.0b3