Closed Bug 1911848 Opened 6 months ago Closed 3 months ago

Simplify tab drop indicator code and styling

Categories

(SeaMonkey :: Tabbed Browser, enhancement)

enhancement

Tracking

(seamonkey2.53+ fixed)

RESOLVED FIXED
Tracking Status
seamonkey2.53 + fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

Details

(Whiteboard: SM2.53.20)

Attachments

(1 file)

Port the relevant changes from:

  • Bug 508499 - simplify tab drop indicator code and styling

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.20
Risk to taking this patch (and alternatives if risky): medium
String changes made by this patch: none

Potentially may break some add-ons, needs testing

Attachment #9417977 - Flags: review?(frgrahl)
Attachment #9417977 - Flags: approval-comm-release?

Comment on attachment 9417977 [details] [diff] [review]
1911848-tabbrowser-tabDrop-25320.patch

lgtm

Firefox code is still much different but probably because we don't support moving a tab to a new window. If no more followups needed we need to reformat the one liner ifs to have brackets one day.

Attachment #9417977 - Flags: review?(frgrahl)
Attachment #9417977 - Flags: review+
Attachment #9417977 - Flags: approval-comm-release?
Attachment #9417977 - Flags: approval-comm-release+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/8b6ff74a6631
Simplify tab drop indicator code and styling. r=frg

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Whiteboard: SM2.53.20
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: