Closed Bug 1911889 Opened 3 months ago Closed 2 months ago

Update the tab icon that indicates sound playing

Categories

(Firefox :: Theme, enhancement)

enhancement

Tracking

()

VERIFIED FIXED
132 Branch
Tracking Status
firefox132 --- verified

People

(Reporter: sfoster, Assigned: kcochrane)

References

Details

(Whiteboard: [fidefe-sidebar])

Attachments

(3 files)

The [specs for the new sidebar and vertical tabs'(https://www.figma.com/design/ZFavpnAJee39j2mFf8U3D0/Sidebar-UX-Spec?node-id=9853-201988&t=oDHfZ60oPKT0Uw6r-0) show a soundplaying icon with a solid background and outline to help legibility. I think we'll probably want to update this for both horizontal and vertical tabs, pinned and not-pinned so have a single consistent treatment.

Type: defect → enhancement
Assignee: nobody → kcochrane
Status: NEW → ASSIGNED
Depends on: 1899580
See Also: 1899580
Attachment #9419689 - Attachment description: Bug 1911889 - Update tab mute/soundplaying icon styling → Bug 1911889 - Update tab mute/soundplaying/activemedia-blocked icon styling
Attachment #9419689 - Attachment description: Bug 1911889 - Update tab mute/soundplaying/activemedia-blocked icon styling → WIP: Bug 1911889 - Update tab mute/soundplaying/activemedia-blocked icon styling
Attachment #9419689 - Attachment description: WIP: Bug 1911889 - Update tab mute/soundplaying/activemedia-blocked icon styling → Bug 1911889 - Update tab mute/soundplaying/activemedia-blocked icon styling
Pushed by kcochrane@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e6b82ff4e092 Update tab mute/soundplaying/activemedia-blocked icon styling r=desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,nsharpley,dao,sclements

Backed out for causing bc failures on browser_tabIconOverlayPiP.js.

[task 2024-09-13T15:37:12.161Z] 15:37:12     INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_tabIconOverlayPiP.js | Tab knows were using PiP - 
[task 2024-09-13T15:37:12.162Z] 15:37:12     INFO - Buffered messages finished
[task 2024-09-13T15:37:12.164Z] 15:37:12     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/pictureinpicture/tests/browser_tabIconOverlayPiP.js | Got the tab-icon-overlay image - "none" == "url(\"chrome://browser/skin/tabbrowser/tab-audio-playing-small.svg\")" - 
[task 2024-09-13T15:37:12.164Z] 15:37:12     INFO - Stack trace:
[task 2024-09-13T15:37:12.165Z] 15:37:12     INFO - chrome://mochitests/content/browser/toolkit/components/pictureinpicture/tests/browser_tabIconOverlayPiP.js:null:72
[task 2024-09-13T15:37:12.165Z] 15:37:12     INFO - resource://testing-common/BrowserTestUtils.sys.mjs:withNewTab:121
[task 2024-09-13T15:37:12.165Z] 15:37:12     INFO - chrome://mochitests/content/browser/toolkit/components/pictureinpicture/tests/browser_tabIconOverlayPiP.js:null:17
[task 2024-09-13T15:37:12.166Z] 15:37:12     INFO - chrome://mochikit/content/browser-test.js:handleTask:1145
[task 2024-09-13T15:37:12.166Z] 15:37:12     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1217
[task 2024-09-13T15:37:12.166Z] 15:37:12     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1358
[task 2024-09-13T15:37:12.167Z] 15:37:12     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1134
[task 2024-09-13T15:37:12.167Z] 15:37:12     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2024-09-13T15:37:12.167Z] 15:37:12     INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_tabIconOverlayPiP.js | Tab is not muted - 
Flags: needinfo?(kcochrane)
Flags: needinfo?(kcochrane)
Pushed by kcochrane@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a13a9d62fb87 Update tab mute/soundplaying/activemedia-blocked icon styling r=desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,nsharpley,dao,sclements
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 132 Branch

This is what the new icon looks like in dark mode for me on Windows 11.

Is this intentional?

The circle around it looks aliased and .... not great IMO.

Caspy7, could you please file a new bug? Thanks!

Flags: needinfo?(caspy77)
See Also: → 1919439

Done.

I have filed bug 1919439.

Flags: needinfo?(caspy77)
Regressions: 1919439
See Also: 1919439

Verified this on Firefox 132.0b5, using Windows 11, macOS 14.7 and Ubuntu 22.04 and the tab soundplaying icon looks the same for both horizontal and vertical tabs, pinned and not-pinned tabs.
However, I've noticed that the sound icon is not updated in the "List ll tabs" menu.
@kcochrane, is that expected? Thank you in advance!

Flags: needinfo?(kcochrane)

Hi, thanks for flagging! I just double checked with UX, and they confirmed we did not want to apply the same styling changes to tabs in the List All Tabs menu.

Flags: needinfo?(kcochrane) → needinfo?(bhidecuti)

Thank you for the confirmation!
Based on Comment 9 I am marking this verified as fixed.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Flags: needinfo?(bhidecuti)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: