1912374 - [Wayland/RTL/Ubuntu 22] Menus flashing when hovering over them

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Moshe]

Steps to reproduce:

This bug applies to Thunderbird also. Menus are in Hebrew.

In Firefox, click on folder in the bookmarks toolbar to show the bookmarks in it, click again to close the folder, then click the folder again and hoover over the bookmarks .

In Thunderbird, click an item in the menu bar, click again to close the menu item, then click the menu item again and hoover over the items.

Actual results:

In Firefox, the folder bookmarks menu flickers. In Thunderbird, the menu flickers. See videos at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/2065382

Expected results:

No flickering of menus should happen in both apps.

See also bug 1902216.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Can you please attach a screencast from Firefox which shows the bug?
https://fedoraproject.org/wiki/How_to_debug_Firefox_problems#Create_screenshot/screencast_for_a_bug_report

Also please attach your about:support page.
Thanks.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Also would be great to test latest nightly directly:
https://fedoraproject.org/wiki/How_to_debug_Firefox_problems#Testing_Mozilla_Nightly_binaries
Thanks.

Comment 4

[Kestrel]

Reproducible by changing intl.l10n.pseudo = bidi on latest Nightly 131.0a1 (2024-08-11) Ubuntu 24.04 Wayland.

Most toolbar menus flicker rapidly when the mouse cursor moves over them, except for the File, View and Help menus. It does not happen with XWayland.

Comment 5

[Kestrel]

Attachment: RTL toolbar menus flickering when moving mouse cursor over them

Comment 6

[Moshe]

Attachment: about:supprt.zip

about:support info.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Thanks, will look at it.

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Mzoregression gives me:

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ef283da5146eca3004d1ab219a5fca8ebb246ef9&tochange=d65395a2bd805a5e66ffe91ef622c195c7a652bb

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Looks like a regression from Bug 1823552. When https://phabricator.services.mozilla.com/D173135 is reverted the menu doesn't flicker (but it's slightly moved).

Emilio, any idea here?
Thanks.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1823552

Comment 11

[Emilio Cobos Álvarez [:emilio]]

I only see this on mutter, fwiw, can't reproduce on KWin...

Comment 12

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1912374 - Account for RTL when moving to a point. r=stransky

We flip the position / anchor alignment on rtl, so we have to choose
different resets there to end up at the requested position.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d92f58fc172
Account for RTL when moving to a point. r=stransky

Comment 14

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/0d92f58fc172

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox130 to wontfix.

For more information, please visit BugBot documentation.

Comment 16

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 9419946 [details]
Bug 1912374 - Account for RTL when moving to a point. r=stransky

Beta/Release Uplift Approval Request

• User impact if declined: Wayland menus on some configurations don't work properly.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 4
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Relatively simple patch
• String changes made/needed: none
• Is Android affected?: No

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9419946 [details]
Bug 1912374 - Account for RTL when moving to a point. r=stransky

This needs bug 1901769 to graft cleanly, which was previously not approved for uplift to Beta. That said, we probably want to take this on ESR128 next cycle alongside that.

Comment 18

[Ina Popescu, Desktop QA]

I've replicated this issue using Nightly 131.0a1(08-08-2024) RTL on Ubuntu 22.04 Wayland following the STR from Comment 4.
Verified as fixed in the latest Nightly 131.0a1 RTL on Ubuntu 22.04 Wayland, as the issue no longer occurs.

Comment 19

[Dianna Smith [:diannaS]]

Comment on attachment 9419946 [details]
Bug 1912374 - Account for RTL when moving to a point. r=stransky

Approved for 128.3esr

Comment 20

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/927837081d96

Comment 21

[Bogdan Maris, Desktop Test Engineering]

Also verified that using latest Firefox 128 esr build from treeherder on Ubuntu 22.04/wayland/RTL this is fixed.