1912404 - bevyengine.org - The animation is not displayed

Status: RESOLVED FIXED

(Web Compatibility :: Site Reports, defect, P1)

Description

[railioaie]

Environment:
Operating System: Linux
Firefox version: Firefox Nightly 131.0a1 (2024-08-08) / Firefox Release 129.0

Preconditions:
Clean profile

Steps to reproduce:

1. Navigate on https://bevyengine.org/examples/animation/animated-fox/
2. Observe the page

Expected Behavior:
The animation is displayed correctly

Actual Behavior:
The animation is not displayed

Notes:

• Reproduces regardless of the status of ETP
• Reproduces in Firefox Nightly, Firefox Release
• Does not reproduce in Chrome

Comment 1

[railioaie]

Attachment: Screenshot from 2024-08-09 12-57-21.png

Comment 2

[jan]

See also the relevant issue on Bevy where a lot of users running into this reported their environment.

Comment 3

[elabajaba]

To summarize the Bevy issue:

As of Firefox 128 Bevy's 3d renderer no longer works with WebGL2 on Linux with AMD Mesa drivers. It appears that Intel mesa drivers and LLVMpipe may also be broken, but those aren't fully confirmed (so this seems to be a Linux Mesa drivers + Firefox 128+ specific issue). There was a recent report that it's also broken as of a recent Firefox 115 ESR release.

I asked about the error message on the wgpu matrix
ERROR Shader compilation failed: ERROR: 0:? : '' : Total size of declared private variables exceeds implementation-defined limit
and was told that this was the relevant code https://searchfox.org/mozilla-central/source/gfx/angle/checkout/src/compiler/translator/ValidateTypeSizeLimitations.cpp#114 and https://searchfox.org/mozilla-central/source/dom/canvas/WebGLShaderValidator.cpp#205

Comment 4

[Dennis Schubert [:denschub]]

According to the GitHub thread, this is a regression from bug 1888340, so maybe the graphics team can look into this. Kelsey, do you have an idea?

Comment 5

[Kelsey Gilbert [:jgilbert]]

I will look

Comment 6

[Pascal Chevrel:pascalc]

Kelsey, did you investigate this regression? Thanks

Comment 7

[Kelsey Gilbert [:jgilbert]]

We can test this on any machine by manually setting webgl.glsl.max_private_var_size_in_bytes.
It looks like the shader requires 69604 here. (69604 renders fine, whereas 69603 has a shader error)

Comment 8

[Kelsey Gilbert [:jgilbert]]

The limit on Mesa is 4*4*1024 -> 16384.

Comment 10

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1912404 - Remove unneeded 16kiB var limit for Mesa.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/989928683ab6
Remove unneeded 16kiB var limit for Mesa. r=gfx-reviewers,lsalzman

Comment 12

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/989928683ab6

Comment 13

[Dianna Smith [:diannaS]]

:jgilbert if you want to uplift this to 131, just a reminder that tomorrow is the last day to request an uplift.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

This grafts cleanly to both Beta and ESR128. Probably worth nominating for both.

Comment 15

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 9424471 [details]
Bug 1912404 - Remove unneeded 16kiB var limit for Mesa.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This limit is low enough that it prevents reasonable content from running, causing websites not to work in Firefox.
• User impact if declined: This limit is low enough that it prevents reasonable content from running, causing websites not to work in Firefox.
• Fix Landed on Version: 132
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Low risk because it doesn't seem like we ever needed this limit, and we know that no one else has this same limit because the content runs elsewhere. (e.g. Chrome)

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9424471 [details]
Bug 1912404 - Remove unneeded 16kiB var limit for Mesa.

Approved for 128.4esr.

Comment 18

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/f14ddef6a7c1