1912936 - mozilla.components.lib.dataprotect.Keystore.encryptBytes crash in [@ android.security.KeyStoreException: at android.security.KeyStore2.getKeyStoreException(KeyStore2.java)]

Status: NEW

(Firefox for Android :: Accounts and Sync, defect, P1)

Description

[Kaya [:kaya]]

Crash report: https://crash-stats.mozilla.org/report/index/d07d2770-02c2-41f5-bc59-61b2c0240813

Report on GPC:

Exception javax.crypto.IllegalBlockSizeException:
  at android.security.keystore2.AndroidKeyStoreCipherSpiBase.engineDoFinal (AndroidKeyStoreCipherSpiBase.java:634)
  at javax.crypto.Cipher.doFinal (Cipher.java:2056)
  at kotlin.collections.MapsKt___MapsKt.forEach (MapsKt___Maps.kt:216)
  at mozilla.components.lib.dataprotect.Keystore.encryptBytes (Keystore.java:167)
  at mozilla.components.lib.dataprotect.SecurePreferencesImpl23.putString (SecureAbove22Preferences.kt:211)
  at mozilla.components.lib.dataprotect.SecureAbove22Preferences.putString (SecureAbove22Preferences.kt:78)
  at mozilla.components.service.fxa.SecureAbove22AccountStorage.write (AccountStorage.kt:258)
  at mozilla.components.service.fxa.StorageWrapper$PersistenceCallback.persist (AccountStorage.kt:58)
  at mozilla.components.service.fxa.FirefoxAccount$WrappingPersistenceCallback.persist (FirefoxAccount.kt:63)
  at mozilla.appservices.fxaclient.FxaClient.tryPersistState (FxaClient.kt:87)
  at mozilla.appservices.fxaclient.FxaClient.access$tryPersistState (FxaClient.kt:22)
  at mozilla.appservices.fxaclient.FxaClient$getAccessToken$1.invoke (FxaClient.kt:291)
  at mozilla.appservices.fxaclient.FxaClient$getAccessToken$1.invoke (FxaClient.kt:287)
  at mozilla.appservices.fxaclient.FxaClient.withMetrics (FxaClient.kt:546)
  at mozilla.appservices.fxaclient.FxaClient.getAccessToken (FxaClient.kt:287)
  at mozilla.appservices.fxaclient.FxaClient.getAccessToken$default (FxaClient.kt:286)
  at mozilla.components.service.fxa.FirefoxAccount$getAccessToken$2$2.invokeSuspend (FirefoxAccount.kt:197)
  at mozilla.components.service.fxa.FirefoxAccount$getAccessToken$2$2.invoke (FirefoxAccount.kt:11)
  at mozilla.components.service.fxa.FirefoxAccount$getAccessToken$2$2.invoke (FirefoxAccount.kt:11)
  at mozilla.components.service.fxa.UtilsKt.handleFxaExceptions (Utils.kt:32)
  at mozilla.components.service.fxa.UtilsKt.handleFxaExceptions (Utils.kt:64)
  at mozilla.components.service.fxa.FirefoxAccount$getAccessToken$2.invokeSuspend (FirefoxAccount.kt:196)
  at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith (ContinuationImpl.kt:33)
  at kotlinx.coroutines.DispatchedTask.run (DispatchedTask.kt:104)
  at kotlinx.coroutines.internal.LimitedDispatcher$Worker.run (LimitedDispatcher.kt:111)
  at kotlinx.coroutines.scheduling.TaskImpl.run (Tasks.kt:99)
  at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely (CoroutineScheduler.java:584)
  at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask (CoroutineScheduler.kt:811)
  at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker (CoroutineScheduler.kt:715)
  at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run (CoroutineScheduler.kt:702)

Comment 1

[Liz Henry (:lizzard) (relman/hg->git project)]

This is very high volume on Nightly 131.

Comment 2

[Kaya [:kaya]]

accidentally overriden Liz's changes. Adding them back.

Comment 4

[Denis Müller [:Webworkr]]

New crash reports from bug 1912863:

https://sentry.io/organizations/mozilla/issues/?project=6295546&query=c87ab35c09b94f199d6d4bb699a82c5c

https://crash-stats.mozilla.org/report/index/bp-391d6e48-8b18-41db-90dc-6a12d0240813

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Based on the topcrash criteria, the crash signatures linked to this bug are not in the topcrash signatures anymore.

For more information, please visit BugBot documentation.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Based on the topcrash criteria, the crash signatures linked to this bug are not in the topcrash signatures anymore.

Since the crash volume is low (less than 15 per week), the severity is downgraded to S3. Feel free to change it back if you think the bug is still critical.

For more information, please visit BugBot documentation.