1913561 - Cover temporary storage initialization in OpenStorageDirectory and OpenClientDirectory

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, task, P1)

Description

[Jan Varga [:janv]]

Quota clients and origin operations currently still have to call EnsureTemporaryStorageIsInitializedInternal method
on the QM IO thread. This should be covered by OpenStorageDirectory and OpenClientDirectory instead.

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1913561 - Add support for initializing temporary storage to QuotaManager::OpenClientDirectory; r=#dom-storage

QuotaManager::OpenClientDirectory can now detect the requested persistence type
and initialize temporary storage if it's needed.

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 1913561 - Remove QuotaManager::EnsureTemporaryStorageIsInitializedInternal calls from places where a directory lock is obtained via QuotaManager::OpenClientDirectory; r=#dom-storage

QuotaManager::OpenClientDirectory already makes sure that temporary storage
is initialized so all these calls are now redundant.

Comment 3

[Jan Varga [:janv]]

Attachment: Bug 1913561 - Add support for initializing temporary storage to QuotaManager::OpenStorageDirectory; r=#dom-storage

QuotaManager::OpenStorageDirectory can now detect the requested persistence
scope and initialize temporary storage if it's needed.

Comment 4

[Jan Varga [:janv]]

Attachment: Bug 1913561 - Remove QuotaManager::EnsureTemporaryStorageIsInitializedInternal calls from places where a directory lock is obtained via QuotaManager::OpenStorageDirectory; r=#dom-storage

QuotaManager::OpenStorageDirectory already makes sure that temporary storage
is initialized so all these calls are now redundant.

Comment 5

[Jan Varga [:janv]]

Attachment: Bug 1913561 - Change QuotaManager::EnsureTemporaryStorageIsInitializedInternal to be a private method; r=#dom-storage

The goal to call QuotaManager::EnsureTemporaryStorageIsInitializedInternal only
from InitTemporaryStorageOp has been achieved. It's now easy to change the
method to be a private method.

Comment 6

[Jan Varga [:janv]]

Attachment: Bug 1913561 - Update QuotaManager gtests to use Await instead of manual spinning of the event loop; r=#dom-storage

TestQuotaManager.cpp is getting big and the use of the Await helper reduces the
size of the file significantly and also make the tests more readable.

Comment 7

[Jan Varga [:janv]]

Attachment: Bug 1913561 - Add more tests for QuotaManager::InitializeTemporaryStorage method; r=#dom-storage

These additional tests are mainly to improve code coverage of
QuotaManager::InitializeTemporaryStorage method.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e71e9e1b3c05
Add support for initializing temporary storage to QuotaManager::OpenClientDirectory; r=dom-storage-reviewers,jari

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/e71e9e1b3c05

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd9998d8fc7c
Remove QuotaManager::EnsureTemporaryStorageIsInitializedInternal calls from places where a directory lock is obtained via QuotaManager::OpenClientDirectory; r=dom-storage-reviewers,jari

Comment 11

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/fd9998d8fc7c

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e75c0736a58
Add support for initializing temporary storage to QuotaManager::OpenStorageDirectory; r=dom-storage-reviewers,jari

Comment 13

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/5e75c0736a58

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0de4d89cea21
Remove QuotaManager::EnsureTemporaryStorageIsInitializedInternal calls from places where a directory lock is obtained via QuotaManager::OpenStorageDirectory; r=dom-storage-reviewers,jari

Comment 15

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/0de4d89cea21

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/895ce008cc48
Change QuotaManager::EnsureTemporaryStorageIsInitializedInternal to be a private method; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/7159f6e61248
Update QuotaManager gtests to use Await instead of manual spinning of the event loop; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/a71f2a1191d8
Add more tests for QuotaManager::InitializeTemporaryStorage method; r=dom-storage-reviewers,jari

Comment 17

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/895ce008cc48
https://hg.mozilla.org/mozilla-central/rev/7159f6e61248
https://hg.mozilla.org/mozilla-central/rev/a71f2a1191d8