1919788 - LSNG: Fix handling of directory locks invalidated during request finalization

Status: RESOLVED FIXED

(Core :: Storage: localStorage & sessionStorage, defect, P2)

Description

[Jan Varga [:janv]]

This is another edge case which is not properly handled, eventually leading to a hang.

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1919788 - LSNG: Add a new testing only notification for request finalization; r=#dom-storage

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 1919788 - LSNG: Add support for pausing DOM File thread during request finalization; r=#dom-storage

Comment 3

[Jan Varga [:janv]]

Attachment: Bug 1919788 - Add a test for origin clearing requested right after starting request finalization for LSNG; r=#dom-storage

Comment 4

[Jan Varga [:janv]]

Attachment: Bug 1919788 - LSNG: Always acquire a directory lock for PreparedDatastoreOp; r=#dom-storage

PrepareDatastoreOp currently skips calling QuotaManager::OpenClientDirectory if
the datastore already exists (is already preloaded). This can lead to a case
when QuotaClient::AbortOperationsForLocks is not able to find a corresponding
object for invalidation (because PrepareDatastoreOp::mDirectoryLock is null),
eventually leading to a hang.
The patch changes the state machine to always start with directory opening, so
there's always a directory lock even if the datastore already has one. This
fixes the problem with potential hang and also improves overall processing
order of incoming requests.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de8c0a8f2cd7
LSNG: Add a new testing only notification for request finalization; r=dom-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/3c5ff4e4053e
LSNG: Add support for pausing DOM File thread during request finalization; r=dom-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/a51dc1d5b857
Add a test for origin clearing requested right after starting request finalization for LSNG; r=dom-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/7d6405ffc070
LSNG: Always acquire a directory lock for PreparedDatastoreOp; r=dom-storage-reviewers,asuth

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/de8c0a8f2cd7
https://hg.mozilla.org/mozilla-central/rev/3c5ff4e4053e
https://hg.mozilla.org/mozilla-central/rev/a51dc1d5b857
https://hg.mozilla.org/mozilla-central/rev/7d6405ffc070