1914155 - Remove the browser.tabs.hoverPreview.enabled pref

Status: ASSIGNED

(Firefox :: Tabbed Browser, task)

Description

[Dão Gottwald [:dao]]

THP is shipped in version 129 using a Nimbus rollout, and bug 1908566 enabled it by default in Nightly 130. Once 130 hits beta, I think we can remove the underlying pref.

Comment 1

[Dão Gottwald [:dao]]

Attachment: WIP: Bug 1914155 - Remove the browser.tabs.hoverPreview.enabled pref.

Comment 2

[Martin]

Hi @dao,

I can see this issue is moving fast now. Is there going to be different way of achieving what browser.tabs.hoverPreview.enabled does or are image previews going to be mandatory for the future? If so could you please link a relevant discussion that led to this? I personally really enjoy the OS style hover tooltip and would hate to see it go.

Comment 3

[Sören Hentzschel]

or are image previews going to be mandatory for the future?

For the image, there is a different pref: browser.tabs.hoverPreview.showThumbnails. Plus, there is a visible setting on about:preferences.

Comment 4

[Dão Gottwald [:dao]]

(In reply to Martin from comment #2)

Hi @dao,

I can see this issue is moving fast now.

I only prepared a patch. Given issues like bug 1912819, I was probably to optimistic in comment 0. I'm not going to land anything here before we're confident we've addressed issues that might make users want to disable our custom previews.

Is there going to be different way of achieving what browser.tabs.hoverPreview.enabled does or are image previews going to be mandatory for the future?

Sören is right, the image is optional regardless, and will remain optional.

Comment 5

[Martin]

Attachment: befaft.png

This the change I was talking about.

Comment 6

[Michael Ozeryansky]

I tried turning off this feature by setting the config to false, but browser.tabs.hoverPreview.enabled keeps turning back to true each time I open Firefox. I turned off "Show an image preview when you hover on a tab" from Settings, but I still see a preview of just the url, which only goes away with the hoverPreview option also being turned off.

Is my issue related, or should I open a new issue?

Comment 7

[Sören Hentzschel]

browser.tabs.hoverPreview.enabled keeps turning back to true each time I open Firefox

Your issue sounds like bug 1914756.

Is my issue related

Not really. This issue is about removing the option browser.tabs.hoverPreview.enabled.

Comment 8

[Michael Ozeryansky]

Yes, exactly that one. Thanks!

Comment 9

[aoia7rz7l]

Please consider not removing this pref at all. Currently the native tooltip clearly indicates which container a tab is in, as well whether or not audio is playing from within that tab. None of these features are currently available in tab hover previews.

FWIW ungoogled-chromium also introduced a custom flag for users who prefer the old tooltip after "regular" Chrome removed the very same flag.

Comment 10

[Sören Hentzschel]

Currently the native tooltip clearly indicates which container a tab is in, as well whether or not audio is playing from within that tab.

The container is already clearly displayed on the tab itself, as is the information whether audio is playing or not. And it's much easier to see as to parse the information in the (old) tooltip. But if you think that it's not enough, you could suggest adding it to the new tab preview.

Comment 11

[aoia7rz7l]

(In reply to Sören Hentzschel from comment #10)

The container is already clearly displayed on the tab itself,

If you switch tabs, yes. Some sites try to detect whether the tab is focused (e.g. bug 1893813) and currently the only way to tell which tab belongs to which container without switching tabs is to use the tooltips. I also use Temporary Containers so container color alone is not enough for me to quickly distinguish between different containers.

as is the information whether audio is playing or not.

Yeah I only mentioned this one as a chrome-parity thing because this is literally yet another Chrome "feature" forced onto Firefox.

And it's much easier to see as to parse the information in the (old) tooltip.

Sorry, but I'd rather parse the tooltip because expecting tooltips and tooltips only is a better experience (IMO) when there are other tooltips in the browser anyway (e.g. bug 1885143?). All I am asking for is an option to keep using tooltips for tab titles.

Comment 12

[Andy Bajka]

Please do not remove browser.tabs.hoverPreview.enabled as it's the only way to remove the distracting hover action which shows a tooltip below the tab.

Comment 13

[Andy Bajka]

Also please fix it so that when we set browser.tabs.hoverPreview.enabled to false, it does not get reverted. I'm not sure what triggers the revert, but I've had it happen twice now in about a week.

Comment 14

[Sören Hentzschel]

Also please fix it so that when we set browser.tabs.hoverPreview.enabled to false, it does not get reverted

This was fixed by bug 1914781 for Firefox 131.

Comment 15

[wojtek]

(In reply to aoia7rz7l from comment #9)

Please consider not removing this pref at all.

+1

I had the issue #1914756 and it was driving me nuts as I consider the hoover pop-up quite awful as it wastes a lot of space and tends to show up/popup accidentally when ones just want to move the cursour out of the way. I already turned of the thumbniles (utterly useles…) and disabled the hoover baloon browser.tabs.hoverPreview.enabled but it kept returning after restart. Wanted to report it and found out that the super compact and unobrusive tooltip is to be removed... :(