1914418 - Idle inhibitors persist and accumulate after a playing video is moved to a different window

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Kestrel]

Attachment: List of accumulated idle inhibitors

STR:

1. Play a video on Ubuntu 24.04.
2. While it is still playing, drag the tab into a new window (or right-click > Move Tab > Move to New Window).
3. Pause and play the video multiple times.
4. Run from terminal:

    dbus-send --print-reply --dest=org.gnome.SessionManager /org/gnome/SessionManager org.gnome.SessionManager.GetInhibitors

Expected:
Inhibitors list is empty when no videos are playing. Screen goes blank after idle timeout.

Actual:
Inhibitors list grows every time video is started. Screen remains on after idle timeout.

Only closing the browser clears the inhibitors list and allows the screen to blank on idle.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0e7c63c931c823b5cc30c784c8c6c1eda03b8eac&tochange=0e96a2dfdd8c67f36e3dabeec9be3cb26f8e2c69

Regressed by Bug 1896235.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:stransky, since you are the author of the regressor, bug 1896235, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1914418 [Linux] Don't recycle g_cancellable r?emilio

Comment 3

[Martin Stránský [:stransky] (ni? me)]

It's because we recycle the g_cancellable which is kept in cancel state. Doc says it's better to release cancellable after cancel operation and create a new one.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef91461da3eb
[Linux] Don't recycle g_cancellable r=emilio

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/ef91461da3eb