1914974 - Update Review Checker Telemetry

Status: RESOLVED FIXED

(Firefox :: Shopping, defect)

Description

[wrocklin]

We want to know if what is displayed to a user in the "more to consider" module, EITHER a sponsored product OR an organic product recommendation.

Comment 1

[Pascal Chevrel:pascalc]

A bug marked as S1 is for major incidents, usually meaning an immediate unplanned dot release asap. This is why request tracking flags were automatically set for the versions of Firefox currently in flight. Will can you confirm that this was not intended and lower the severity? Thanks! :)

S1 (Catastrophic) Blocks development/testing, may impact more than 25% of users, causes data loss, likely dot release driver, and no workaround available

Comment 2

[wrocklin]

Lowered to S2

Comment 3

[Fred Chasen [:fchasen]]

Attachment: Bug 1914974: Update Review Checker telemetry to record if a recommendation was sponsored. r=#shopping-reviewers!

• Adds an extra sponsored key to pass if the recommendation was sponsored or not to surface_ads_placement, surface_ads_impression and surface_ads_clicked.
• Only records ads_exposure and sends attribution events for sponsored recommendations.
• Parses the JSON response in exposure telemetry tests.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6024af71dec5
Update Review Checker telemetry to record if a recommendation was sponsored. r=shopping-reviewers,kpatenio

Comment 5

[Noemi Erli[:noemi_erli]]

Backed out changeset 6024af71dec5 (Bug 1914974) for causing failures in browser_shopping_ads_test.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=6024af71dec5c5f2f47be4757e31867ca9534edb&selectedTaskRun=BomVvHaXS1mn-TEKlHoIyg.0

Log: https://treeherder.mozilla.org/logviewer?job_id=472018562&repo=autoland&lineNumber=15776
https://treeherder.mozilla.org/logviewer?job_id=472018611&repo=autoland&lineNumber=2576

Backout: https://hg.mozilla.org/integration/autoland/rev/5994bccc3445f047f5809faa9f05ea0674aaf074

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/112e5d8b6171
Update Review Checker telemetry to record if a recommendation was sponsored. r=shopping-reviewers,kpatenio

Comment 7

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/112e5d8b6171