1915007 - View>Sidebar options duplicate on pref flip and add other sidebar panels that aren't enabled

Status: RESOLVED FIXED

(Firefox :: Sidebar, defect, P3)

Description

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Screenshot 2024-08-26 at 2.16.01 PM.png

STR: Go to Firefox labs in about:preferences. Select and unselect "sidebar" a few times. Go to View > Sidebar in your OS. You should see that the sidebar options duplicate every time "sidebar" is selected.

Comment 3

[Sarah Clements [:sclements]]

Ed said this is really obvious when testing out the sidebar experiment so we should fix this for 132.

Comment 4

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 1915007 - Avoid duplicate View>Sidebar menu items on sidebar pref flip r=#sidebar-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7e1c167b99b
Avoid duplicate View>Sidebar menu items on sidebar pref flip r=sidebar-reviewers,Gijs

Comment 6

[Cosmin Sabou [:CosminS]]

Backed out changeset f7e1c167b99b (Bug 1915007) for causing bc failures on browser_view_sidebar_menu.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=539ec2225afbea690e887ef3e12befbfb797c8ca&selectedTaskRun=CGSTy2LPQRudPm-n0y_qcw.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=477511727&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/58a5b3c5983fac0b3c2e72a5fdfdf931418f4c3d

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57328284b6fc
Avoid duplicate View>Sidebar menu items on sidebar pref flip r=sidebar-reviewers,Gijs

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/57328284b6fc

Comment 9

[Monica Chiorean]

I was able to reproduce the issue on Ubuntu24.04/Win11 using FF build 133.0a1(2024-10-01).
Verified as fixed on Ubuntu24.04/Win11 using FF builds 134.0a1(2024-11-07). For beta the sidebar is not available in Firefox Labs so I tried with pref flip in about config, but not reproducing.