1915123 - Debugger editor gutter with cm6 traps keyboard navigation on resource://activity-stream/data/content/activity-stream.bundle.js

Status: NEW

(DevTools :: Debugger, defect, P2)

Description

[Julian Descottes [:jdescottes]]

Spotted while testing Bug 1913693

STRs:

• set devtools.debugger.features.codemirror-next to true
• open devtools > debugger
• select any source
• focus the editor
• press shift + tab (this should move the focus to the line gutter on the left of the editor)
• try to press shift+tab until you can leave the gutter

ER: Should be able to reach the rest of the debugger UI
AR: Focus keeps cycling on the expand buttons in the gutter

Comment 1

[Julian Descottes [:jdescottes]]

Doesn't seem to reproduce on another source, need to investigate and find better STRs or close.

Comment 2

[Julian Descottes [:jdescottes]]

That seems to only happen on some specific files and only with the patch from Bug 1913693 ?

STRs:

• open about:newtab
• open devtools > debugger
• open resource://activity-stream/data/content/activity-stream.bundle.js (should be under Main Thread)
• shift tab and try to keep pressing shift tab to leave the gutter

Hubert, can you check if you repro this with your patches from Bug 1913693?

Comment 3

[Hubert Boma Manilla (:bomsy)]

(In reply to Julian Descottes [:jdescottes] from comment #2)

That seems to only happen on some specific files and only with the patch from Bug 1913693 ?

STRs:

• open about:newtab
• open devtools > debugger
• open resource://activity-stream/data/content/activity-stream.bundle.js (should be under Main Thread)
• shift tab and try to keep pressing shift tab to leave the gutter

Hubert, can you check if you repro this with your patches from Bug 1913693?

Was able to reproduce. This issue is mainly with large sources that are scrollable. This seems to relate to the CM^ virtualization.

Tabbing through the gutter causes the editor to scroll, which would re-render the current viewport when the scroll threshold is reached, this losses the current focused element as it'll get removed from the viewport. Tabbing again should cause the next gutter element to get selected again and the cycle repeats itself, therefore not allowing the focus not to leave the editor.