Closed Bug 1913693 Opened 2 months ago Closed 1 month ago

Remove legacy code to handling escaping out of the debugger editor which is causing issues

Categories

(DevTools :: Debugger, defect, P3)

defect

Tracking

(firefox131 fixed)

RESOLVED FIXED
131 Branch
Tracking Status
firefox131 --- fixed

People

(Reporter: bomsy, Assigned: bomsy)

References

(Blocks 3 open bugs)

Details

Attachments

(1 file)

This is some legacy code probably added to fix an issue which seems to no longer exist. See https://searchfox.org/mozilla-central/rev/2455e4d6388cbdeadb44b9633b971a65a98b504c/devtools/client/debugger/src/components/Editor/index.js#472-487. One effect of this is that we need to hit Esc twice to open the split console, when focused in the debugger. But we should only have to hit esc once.

STR

  • Open any source in the debugger
  • Click in the editor at any position
  • Press Esc

Expected Result

The split console should open

Actual Result

Nothing happens (Needs a second escape to open the split console)

Summary: Remove legacy code to handle escaping out of the debugger editor → Remove legacy code to handling escaping out of the debugger editor which is causing issues
Blocks: 1900395
Assignee: nobody → hmanilla
Status: NEW → ASSIGNED
Severity: -- → S3
Priority: -- → P3
Pushed by hmanilla@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c88bf4be8ae7 [devtools] Cleanup legacy code added to handle escaping out of the editor r=devtools-reviewers,jdescottes
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 131 Branch
Regressions: 1915636
QA Whiteboard: [qa-131b-p2]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: