1915214 - Outgoing server settings aren't shown in the UI

Status: RESOLVED FIXED

(MailNews Core :: Networking: Exchange, defect, P1)

Description

[Alessandro Castellani [:aleca]]

Attachment: Screenshot 2024-08-14 at 11.06.59 AM.png

STR

• Have an Exchange account configured.
• Access the Outgoing SMTP page in the Account settings tab.
• Double click (or edit) the Exchange outgoing server.

The dialog is empty of any data.

Comment 1

[Magnus Melin [:mkmelin]]

JavaScript error: chrome://messenger/content/SmtpServerEdit.js, line 75: NS_NOINTERFACE: Component returned failure code: 0x80004002 (NS_NOINTERFACE) [nsISupports.QueryInterface]

Comment 3

[Brendan Abolivier [:babolivier]]

Attachment: Bug 1915214 - Support displaying settings for non-SMTP outgoing servers. r=#thunderbird-front-end-reviewers

I've decided to de-scope manual config for non-SMTP servers for now. As a
result, this patch also makes it so the edit buttons for the outgoing server's
configuration are disabled if the server isn't SMTP. This brings the state of
the outgoing config to a more or less similar state as the incoming one, and
makes the account settings UI less confusing until we fully support manual
config.

Since the goal of this patch is to make things less confusing for users of
non-SMTP servers (e.g. Exchange), I've also updated the L10n strings to not
mention SMTP by name. I've also updated the outgoing server settings table to
display the server type (since otherwise it's barely possible to differentiate
e.g. an Exchange server from an SMTP one).

Comment 4

[Magnus Melin [:mkmelin]]

When it's not SMTP it's really the incoming server settings. I believe there's internally a bit code confusion for that. I mean, in and out are now separate configurations, but should never be treated as such AFAIK. There is really only two options: SMTP, or "Use incoming for outgoing".
I think we should at least for the UI only do something that reflects that - but it would probably be best to re-work the backend for it as well. If any setting ever changes for incoming and goes out of sync for outgoing due to that... that's not going to end well.

Comment 5

[Brendan Abolivier [:babolivier]]

(In reply to Magnus Melin [:mkmelin] from comment #4)

When it's not SMTP it's really the incoming server settings. I believe there's internally a bit code confusion for that. I mean, in and out are now separate configurations, but should never be treated as such AFAIK. There is really only two options: SMTP, or "Use incoming for outgoing".
I think we should at least for the UI only do something that reflects that - but it would probably be best to re-work the backend for it as well. If any setting ever changes for incoming and goes out of sync for outgoing due to that... that's not going to end well.

I agree. Though until the backend is reworked into a shape that allows simply reusing the incoming settings for outgoing servers, then I'm less comfortable tweaking the UI into tricking the user that it already does.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/79ca1a3d2cfa
Support displaying settings for non-SMTP outgoing servers. r=freaktechnik